From patchwork Tue Mar 23 14:36:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 11671 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 92BCEC32E7 for ; Tue, 23 Mar 2021 14:36:25 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 400A368D83; Tue, 23 Mar 2021 15:36:25 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="gujPtEfX"; dkim-atps=neutral Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 850DC68D63 for ; Tue, 23 Mar 2021 15:36:21 +0100 (CET) Received: by mail-ed1-x533.google.com with SMTP id dm8so23737751edb.2 for ; Tue, 23 Mar 2021 07:36:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IBYOmNhWc9VLgjJTDXl+uYxRIPrJR5MK3Zb55BkFyfk=; b=gujPtEfXy7EvG/l0MAVbigoYUPDz+JBzH90x7LmvGXKtKSLzBeR/OuQ1DWIPgc7YBa dAIOJK+Ml6NB/ynICLLaRh+tRU+eBrQai8O26bX10OVL4YrHnmij8vvDsl1S855gyQ/j xzLlhOMWcvO3K/nr/Gqk2hCA/SEUxS7KJTR4teFaZD9m9NRYuPlqSqy1Re/b2AVKdeDf QZMKrq0C/kV4XoKaeBJwlqUVyU76HaMx24W1SgpCneI8+9WDOilVg8YKZBG0jFblwN90 8IaoY6NUTuW9nocpuJS+qy7CTNX5RQrP+l2W/QCxk/GG8pgtfy8LqmKub7sKZYx0e1bF vNjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IBYOmNhWc9VLgjJTDXl+uYxRIPrJR5MK3Zb55BkFyfk=; b=SoX36g2Ix/oDnFxk0tQv8ykAxVm5UHzqvcQAiCyvlMq6LLbGm7HgBC4yN8sT2hzP83 94viizE4fyptqIYk5a3zCoFemSq3EoWpS7c8AbQC6tVuZ9ZROYhA4jB/HtHEDL68vard NvCFzM0Zhs2uQwaUHzwgvrtAJKy06fbfxSLP+oVSMQk7LbvRVM/UcvJuizXQkJCmWGXn HcsKGgbpaDBRyOWU5VabHBn4v4L3XKbmtQT6LYEaoQmPEaiYSDgIAMiKoTK7LQ5APPkW gBWqsGxeXneXptJfNNLCE2vCjTePsx7ZIfVxdqrfUEFulDCjXWajYoCuOumZOnoYmJ+f zkyQ== X-Gm-Message-State: AOAM532dGYYnV7Kg4gcJ4l9preIY4f+G7j56Pkm+CLUXl/67obnpFl23 9R5MsDAf+RQ7Vr3cdlPeCxseX5mcozZr/Q== X-Google-Smtp-Source: ABdhPJxsmnq2byDec0OfGiWG4Z9+oudIlYCz/+G/o3aYNi3eNIGp144KnLqTO5oY+sJBsBgducjifA== X-Received: by 2002:aa7:c9d1:: with SMTP id i17mr4807220edt.46.1616510180924; Tue, 23 Mar 2021 07:36:20 -0700 (PDT) Received: from naush-laptop.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id n6sm11282430eji.37.2021.03.23.07.36.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 07:36:20 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Tue, 23 Mar 2021 14:36:08 +0000 Message-Id: <20210323143610.787760-6-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210323143610.787760-1-naush@raspberrypi.com> References: <20210323143610.787760-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 5/7] ipa: raspberrypi: Remove unused member variable X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The lastMode_ member variable is now unused, so remove it. Signed-off-by: Naushir Patuck Tested-by: David Plowman Reviewed-by: Laurent Pinchart --- src/ipa/raspberrypi/raspberrypi.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp index bd20b144f520..93e43f0626fb 100644 --- a/src/ipa/raspberrypi/raspberrypi.cpp +++ b/src/ipa/raspberrypi/raspberrypi.cpp @@ -67,8 +67,8 @@ class IPARPi : public ipa::RPi::IPARPiInterface { public: IPARPi() - : lastMode_({}), controller_(), frameCount_(0), checkCount_(0), - mistrustCount_(0), lsTable_(nullptr), firstStart_(true) + : controller_(), frameCount_(0), checkCount_(0), mistrustCount_(0), + lsTable_(nullptr), firstStart_(true) { } @@ -128,7 +128,6 @@ private: /* Camera sensor params. */ CameraMode mode_; - CameraMode lastMode_; /* Raspberry Pi controller specific defines. */ std::unique_ptr helper_; @@ -383,8 +382,6 @@ int IPARPi::configure(const CameraSensorInfo &sensorInfo, result->controls = std::move(ctrls); } - lastMode_ = mode_; - return 0; }