From patchwork Tue Mar 23 12:27:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 11662 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 678FBC32E5 for ; Tue, 23 Mar 2021 12:27:54 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 14E2168D74; Tue, 23 Mar 2021 13:27:54 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="Ms78kzWY"; dkim-atps=neutral Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 12C7968D63 for ; Tue, 23 Mar 2021 13:27:49 +0100 (CET) Received: by mail-ed1-x535.google.com with SMTP id h10so23181787edt.13 for ; Tue, 23 Mar 2021 05:27:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IBYOmNhWc9VLgjJTDXl+uYxRIPrJR5MK3Zb55BkFyfk=; b=Ms78kzWYh92HCLb/q5jAbav20/7Nfjdb/mimJi4ezoCQthDWsq25gKXeLlXlQsLAHm XxcK9JG6OD2bb0MQDO17XXYKZylEPBXBh99wlY3Kog0UpP1gpFKqoTehtFa5dTAzr0pg 3QJm+Rn4VY/jWA3DU1o8w0fq2T2Mh5QwX/as639t9ShQkJ9K8L6J46Ur2JcpSqOFUoFZ GrEhyDv3Lmnj7bj5d+fBY93qG1mxmWtqQDSmLZbfrYv0csImOSc3XDx16KfCk9iG3B2E /vev+cM1c48Emyt1wytpaQ4soImcyHjT1gi9L8dBxT3xyd/VWF5chKFRxtLECrCzAxfQ 3bWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IBYOmNhWc9VLgjJTDXl+uYxRIPrJR5MK3Zb55BkFyfk=; b=UPcP4nwrDGXoLdsbuccSBI0u6YvC2ppzqzEbeF1IpWaGTeR6tSjnflQ6IKOK3UFJBb I14fU+UiMhhSLVnQTntrpP0+9bCYawYO6mZC8EP6oc4E2yqo9hhbnWh1zfB6LsbGGVVV pnIM8nfWwi+QXGZZWPcGXhTg6UAX4ksjuPi34h2NoMWxOK78DW1WBxwoPuDaIBh9pw6c j9tioSYzHz5gJ5A8Vfwe8fcO6B9aYLWAaurNmtLGPjz/X2bNJZ4PwWI3NI4Dqa54Z46N arD1nMbTKzPfTrBp+C7QaSzqsyNaeOwQ21h5KqirxHGXAU67+v2Tz3scEvhOVBH1fugI 82nQ== X-Gm-Message-State: AOAM531BRa1sGs2poQuf6aWKonLCCZsIey+LG1fwj1xNjgoGO2kvTyUI Yxp2dfpkcU/ceo/kp6KVs3QwaK3JT5z3RQ== X-Google-Smtp-Source: ABdhPJx7lhFmtOCOCAnup7LXGpUpVlNQLLPPooB9U6mUIwdC88i7Ivk4vYv8vPaspUJk3eu5gu+wSA== X-Received: by 2002:a05:6402:1d1a:: with SMTP id dg26mr4291130edb.266.1616502468449; Tue, 23 Mar 2021 05:27:48 -0700 (PDT) Received: from naush-laptop.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id u13sm11082295ejy.31.2021.03.23.05.27.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 05:27:48 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Tue, 23 Mar 2021 12:27:37 +0000 Message-Id: <20210323122739.680560-6-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210323122739.680560-1-naush@raspberrypi.com> References: <20210323122739.680560-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 5/7] ipa: raspberrypi: Remove unused member variable X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The lastMode_ member variable is now unused, so remove it. Signed-off-by: Naushir Patuck Tested-by: David Plowman Reviewed-by: Laurent Pinchart --- src/ipa/raspberrypi/raspberrypi.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp index bd20b144f520..93e43f0626fb 100644 --- a/src/ipa/raspberrypi/raspberrypi.cpp +++ b/src/ipa/raspberrypi/raspberrypi.cpp @@ -67,8 +67,8 @@ class IPARPi : public ipa::RPi::IPARPiInterface { public: IPARPi() - : lastMode_({}), controller_(), frameCount_(0), checkCount_(0), - mistrustCount_(0), lsTable_(nullptr), firstStart_(true) + : controller_(), frameCount_(0), checkCount_(0), mistrustCount_(0), + lsTable_(nullptr), firstStart_(true) { } @@ -128,7 +128,6 @@ private: /* Camera sensor params. */ CameraMode mode_; - CameraMode lastMode_; /* Raspberry Pi controller specific defines. */ std::unique_ptr helper_; @@ -383,8 +382,6 @@ int IPARPi::configure(const CameraSensorInfo &sensorInfo, result->controls = std::move(ctrls); } - lastMode_ = mode_; - return 0; }