From patchwork Thu Mar 18 14:11:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marian Cichy X-Patchwork-Id: 11624 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 2C9D1C32E1 for ; Thu, 18 Mar 2021 14:11:42 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id AA46F602E3; Thu, 18 Mar 2021 15:11:41 +0100 (CET) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B982602DB for ; Thu, 18 Mar 2021 15:11:40 +0100 (CET) Received: from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMtND-0001t4-M2; Thu, 18 Mar 2021 15:11:39 +0100 Received: from mci by dude02.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lMtND-000394-Dd; Thu, 18 Mar 2021 15:11:39 +0100 From: Marian Cichy To: libcamera-devel@lists.libcamera.org Date: Thu, 18 Mar 2021 15:11:24 +0100 Message-Id: <20210318141124.12014-1-m.cichy@pengutronix.de> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::28 X-SA-Exim-Mail-From: mci@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: libcamera-devel@lists.libcamera.org Subject: [libcamera-devel] [PATCH] libcamera: request: Fix documentation of controls() method X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: graphics@pengutronix.de, Marian Cichy Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The documentation of the controls() method refers to the methods ControlList::operator[]() and ControlList::update(), which do not exist. Instead refer to ControlList::get() and ControlList::set() to achieve a similar documentation. Signed-off-by: Marian Cichy Reviewed-by: Laurent Pinchart --- src/libcamera/request.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp index 24c3694d..fe521ae2 100644 --- a/src/libcamera/request.cpp +++ b/src/libcamera/request.cpp @@ -138,8 +138,8 @@ void Request::reuse(ReuseFlag flags) * * Requests store a list of controls to be applied to all frames captured for * the request. They are created with an empty list of controls that can be - * accessed through this method and updated with ControlList::operator[]() or - * ControlList::update(). + * accessed through this method. Control values can be retrieved using + * Control::get() and updated using Control::set(). * * Only controls supported by the camera to which this request will be * submitted shall be included in the controls list. Attempting to add an