From patchwork Wed Mar 17 19:28:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 11611 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E4A88BD80C for ; Wed, 17 Mar 2021 22:53:49 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5DFB568D51; Wed, 17 Mar 2021 23:53:48 +0100 (CET) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8DB7B68D61 for ; Wed, 17 Mar 2021 20:29:21 +0100 (CET) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: nfraprado) with ESMTPSA id D22BC1F453D8 From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= To: libcamera-devel@lists.libcamera.org Date: Wed, 17 Mar 2021 16:28:30 -0300 Message-Id: <20210317192831.359014-5-nfraprado@collabora.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210317192831.359014-1-nfraprado@collabora.com> References: <20210317192831.359014-1-nfraprado@collabora.com> MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 17 Mar 2021 23:53:43 +0100 Subject: [libcamera-devel] [PATCH 4/5] Documentation: guides: pipeline-handler: Update code, commands and logs X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Chinchilla , Sebastian Fricke Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The pipeline-handler guide is a bit outdated: - ControlList* in start() is now const. - Registered pipeline handler log now comes from Camera log and the message is different. Update the pipeline-handler guide to reflect these changes. Signed-off-by: Nícolas F. R. A. Prado Reviewed-by: Sebastian Fricke Reviewed-by: Laurent Pinchart --- Documentation/guides/pipeline-handler.rst | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst index 43783ec32afa..bcce86793ccd 100644 --- a/Documentation/guides/pipeline-handler.rst +++ b/Documentation/guides/pipeline-handler.rst @@ -209,7 +209,7 @@ methods for the overridden class members. int exportFrameBuffers(Camera *camera, Stream *stream, std::vector> *buffers) override; - int start(Camera *camera, ControlList *controls) override; + int start(Camera *camera, const ControlList *controls) override; void stop(Camera *camera) override; int queueRequestDevice(Camera *camera, Request *request) override; @@ -239,7 +239,7 @@ methods for the overridden class members. return -1; } - int PipelineHandlerVivid::start(Camera *camera, ControlList *controls) + int PipelineHandlerVivid::start(Camera *camera, const ControlList *controls) { return -1; } @@ -303,13 +303,13 @@ new pipeline handler by running: .. code-block:: shell - LIBCAMERA_LOG_LEVELS=Pipeline:0 ./build/src/cam/cam -l + LIBCAMERA_LOG_LEVELS=Camera:0 ./build/src/cam/cam -l And you should see output like the below: .. code-block:: shell - DEBUG Pipeline pipeline_handler.cpp:680 Registered pipeline handler "PipelineHandlerVivid" + DEBUG Camera camera_manager.cpp:148 Found registered pipeline handler 'PipelineHandlerVivid' Matching devices ~~~~~~~~~~~~~~~~