From patchwork Wed Mar 17 10:02:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 11603 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C0B2EBD80C for ; Wed, 17 Mar 2021 10:02:27 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 68BAF68D69; Wed, 17 Mar 2021 11:02:27 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="p/UYiYC/"; dkim-atps=neutral Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 782ED68D60 for ; Wed, 17 Mar 2021 11:02:22 +0100 (CET) Received: by mail-ed1-x532.google.com with SMTP id x21so1482178eds.4 for ; Wed, 17 Mar 2021 03:02:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=i0Iw9t0eXvZQY0D2HztYUW+2hZU4Zj5K8M2ZQyPbQEM=; b=p/UYiYC/PvkKpoQ7HG9xvsiR676BKSAJcoDM+mmemyImGh+UFb9bJUSuXbgijE2NW2 3V8bi39XP8HU4SvvzWUTwwWWJdrKeGkFM8uphU95k+RY0QZRQbkB6x+myIS+D3IeAvBk SlLSBp1bXdAlng3WuUwlny6u1OES2Fzz5IplyHFTYvp0S56DZpiw3tQS4W2/p6poLQt/ d2cYLX6/W2J5UzeQ1jQAdqQ3Yp3xwzYLKtEAsSpiXa6dYwiiJdMcyqN61RDMPUVPMwJI 6nsAPvxBB9JCortIoWawrkoQTPbEmE5F594ysLX+PwgR6w/lQMz9GStZqHPV1Bgud7Pb B+wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i0Iw9t0eXvZQY0D2HztYUW+2hZU4Zj5K8M2ZQyPbQEM=; b=eDaUhpU+OkaaRXN/GsyzHGbQGqfL2UXIJXKU9TXJqZ510t5J2ryjjfv+PVuKF4dR0e 8b2lst+Frtn/2N+4pqNHe8ybW3QVOUx9okLskHux+3Cngoj/yH+Iq8AtNdCFEQXM/q/M Del4z9KmbF4KtVPmmsvaTyg50DdQRGGSfVPNIo05smaTI+wiAF+kd2HBzEyTWC2fsMPT UpSEZUEKrNWhOXOSMDVMV60FadOAf35ElDd+cmtmWaxtQbzrn9zGRuBO42b8+iVE9i66 prUA6C9cSsu/4ixgS44O3HnwSeagbzlmhERBQcLJkaKmMTz69muVeW5nw90UFPTEvlF/ RS9g== X-Gm-Message-State: AOAM5315mz6krmUPA5oA1Zj0BsDYgpgWJWBBkj8uHwO28IMH9JXDyKVd QMUxewq+5mVpMZH2lzA+CMOTK/huo2f3Eg== X-Google-Smtp-Source: ABdhPJyY96jlYd7Ec/ex3GbYHsoln98LVTuaojuX9IqIQZvBo/6E631FfMfArbLxkbNn8QtnwlzIKA== X-Received: by 2002:a05:6402:b85:: with SMTP id cf5mr42025200edb.248.1615975341945; Wed, 17 Mar 2021 03:02:21 -0700 (PDT) Received: from naush-laptop.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id p24sm12061179edt.5.2021.03.17.03.02.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 03:02:21 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Wed, 17 Mar 2021 10:02:09 +0000 Message-Id: <20210317100211.1067585-6-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210317100211.1067585-1-naush@raspberrypi.com> References: <20210317100211.1067585-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 5/7] ipa: raspberrypi: Remove unused member variables X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" With the recent refactoring of code from ipa::configure() to ipa::init() some member variable are now unused, so remove them. Signed-off-by: Naushir Patuck Reviewed-by: Laurent Pinchart --- src/ipa/raspberrypi/raspberrypi.cpp | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp index e2db0716b84b..2ca64bcdb80a 100644 --- a/src/ipa/raspberrypi/raspberrypi.cpp +++ b/src/ipa/raspberrypi/raspberrypi.cpp @@ -67,8 +67,7 @@ class IPARPi : public ipa::RPi::IPARPiInterface { public: IPARPi() - : lastMode_({}), controller_(), controllerInit_(false), - frameCount_(0), checkCount_(0), mistrustCount_(0), + : controller_(), frameCount_(0), checkCount_(0), mistrustCount_(0), lsTable_(nullptr), firstStart_(true) { } @@ -129,12 +128,10 @@ private: /* Camera sensor params. */ CameraMode mode_; - CameraMode lastMode_; /* Raspberry Pi controller specific defines. */ std::unique_ptr helper_; RPiController::Controller controller_; - bool controllerInit_; RPiController::Metadata rpiMetadata_; /* @@ -387,8 +384,6 @@ int IPARPi::configure(const CameraSensorInfo &sensorInfo, result->controls = std::move(ctrls); } - lastMode_ = mode_; - return 0; }