From patchwork Mon Mar 8 10:13:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 11513 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 19796BD1F1 for ; Mon, 8 Mar 2021 10:14:15 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CA84068AA8; Mon, 8 Mar 2021 11:14:14 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="tfnwfDaI"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id CB48468A99 for ; Mon, 8 Mar 2021 11:14:13 +0100 (CET) Received: from pyrite.rasen.tech (unknown [IPv6:2400:4051:61:600:2c71:1b79:d06d:5032]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6270B8A3; Mon, 8 Mar 2021 11:14:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1615198453; bh=/Fx8yyQSgzgGtv+B7QuSN2Qw6K+T90Wo0Sas2I6MEpU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tfnwfDaI4smfYzks6zj6TMVEN66R+Qzy3YnYzK2CaZNZc5bmVAwMDvdZfoxPX02O9 zh374QSfYFgIdQHK1tuOuTZJaEyGNlkYTAX2S2hx+Pa+xbo7i0ffaSOFMioAZ5Ll6p qfKwWjnnnlfS1HVe54UADeuLZq9BHtkHotkD5rRQ= From: Paul Elder To: libcamera-devel@lists.libcamera.org Date: Mon, 8 Mar 2021 19:13:56 +0900 Message-Id: <20210308101356.59333-5-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210308101356.59333-1-paul.elder@ideasonboard.com> References: <20210308101356.59333-1-paul.elder@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 4/4] android: jpeg: exif: change GPS method from UNDEFINED format to ASCII X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" According to the EXIF specification, the GPS method should be UNDEFINED, and the first 8 bytes will designate the type. However, CTS expects the GPS method to be ASCII. Change the format to ASCII to appease CTS. This is part of the fix that allows the following CTS test to pass: - android.hardware.cts.CameraTest#testJpegExif Signed-off-by: Paul Elder --- src/android/jpeg/exif.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/android/jpeg/exif.cpp b/src/android/jpeg/exif.cpp index 5225d17f..83e6faba 100644 --- a/src/android/jpeg/exif.cpp +++ b/src/android/jpeg/exif.cpp @@ -404,7 +404,7 @@ void Exif::setGPSLocation(const double *coords) void Exif::setGPSMethod(const std::string &method) { setString(EXIF_IFD_GPS, static_cast(EXIF_TAG_GPS_PROCESSING_METHOD), - EXIF_FORMAT_UNDEFINED, method, Unicode); + EXIF_FORMAT_ASCII, method); } void Exif::setOrientation(int orientation)