From patchwork Tue Mar 2 14:18:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 11455 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A6E98BD808 for ; Tue, 2 Mar 2021 14:18:36 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8420968A9A; Tue, 2 Mar 2021 15:18:36 +0100 (CET) Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [217.70.178.232]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E207768A96 for ; Tue, 2 Mar 2021 15:18:34 +0100 (CET) Received: from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it [93.61.96.190]) (Authenticated sender: jacopo@jmondi.org) by relay12.mail.gandi.net (Postfix) with ESMTPSA id AF97020000A; Tue, 2 Mar 2021 14:18:33 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Tue, 2 Mar 2021 15:18:41 +0100 Message-Id: <20210302141844.126634-9-jacopo@jmondi.org> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210302141844.126634-1-jacopo@jmondi.org> References: <20210302141844.126634-1-jacopo@jmondi.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 08/11] android: camera_buffer: Add method to get the JPEG blob size X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Han-lin Chen , Daniel Hung-yu Wu Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" To maintain compatibility with platforms that do not provide a memory backend implementation add a method to be return the size of the buffer used for JPEG encoding capped to a maximum size. Platforms that implement a memory backend will always calculate the correct buffer size. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart --- src/android/camera_buffer.h | 2 ++ src/android/mm/generic_camera_buffer.cpp | 14 ++++++++++++++ 2 files changed, 16 insertions(+) diff --git a/src/android/camera_buffer.h b/src/android/camera_buffer.h index 2311cdaf96b2..784fbd50e50b 100644 --- a/src/android/camera_buffer.h +++ b/src/android/camera_buffer.h @@ -26,6 +26,8 @@ public: libcamera::Span plane(unsigned int plane) const; libcamera::Span plane(unsigned int plane); + + size_t jpegBufferSize(size_t maxJpegBufferSize) const; }; #endif /* __ANDROID_CAMERA_BUFFER_H__ */ diff --git a/src/android/mm/generic_camera_buffer.cpp b/src/android/mm/generic_camera_buffer.cpp index 45a83c351266..98e63dfa0577 100644 --- a/src/android/mm/generic_camera_buffer.cpp +++ b/src/android/mm/generic_camera_buffer.cpp @@ -27,6 +27,8 @@ public: unsigned int numPlanes() const; Span plane(unsigned int plane); + + size_t jpegBufferSize(size_t maxJpegBufferSize) const; }; CameraBuffer::Private::Private(CameraBuffer *cameraBuffer, @@ -77,6 +79,12 @@ Span CameraBuffer::Private::plane(unsigned int plane) return maps_[plane]; } +size_t CameraBuffer::Private::jpegBufferSize(size_t maxJpegBufferSize) const +{ + return std::min(maps_[0].size(), + maxJpegBufferSize); +} + CameraBuffer::CameraBuffer(buffer_handle_t camera3Buffer, int flags) : Extensible(new Private(this, camera3Buffer, flags)) { @@ -109,3 +117,9 @@ Span CameraBuffer::plane(unsigned int plane) Private *const d = LIBCAMERA_D_PTR(); return d->plane(plane); } + +size_t CameraBuffer::jpegBufferSize(size_t maxJpegBufferSize) const +{ + const Private *const d = LIBCAMERA_D_PTR(); + return d->jpegBufferSize(maxJpegBufferSize); +}