From patchwork Mon Mar 1 06:52:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 11410 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8DA95BD808 for ; Mon, 1 Mar 2021 06:52:39 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 553D268A84; Mon, 1 Mar 2021 07:52:39 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="D44+JZlQ"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 18A0F68A84 for ; Mon, 1 Mar 2021 07:52:37 +0100 (CET) Received: from pyrite.rasen.tech (unknown [IPv6:2400:4051:61:600:2c71:1b79:d06d:5032]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8303D332; Mon, 1 Mar 2021 07:52:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1614581556; bh=O71AxfC6sgufsJo1h1G9W2x6e+kVv4UBydqtlB1Z8BU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D44+JZlQiosYpxs82xuJ/9+Lru49aeL14+ifXJtkqZUviRX/13GqXgd/hHxbAXwF/ MaLKVFOnJXro7IT07xOpaO5g2wrjMLAEYSfXsiAqgb6BUbkC27eaDJfLZn5XKrI2e6 rBj306yxi/vLSEGU9oW5c7wk+6sEn1U7C3hwqCO4= From: Paul Elder To: libcamera-devel@lists.libcamera.org Date: Mon, 1 Mar 2021 15:52:24 +0900 Message-Id: <20210301065226.11095-2-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210301065226.11095-1-paul.elder@ideasonboard.com> References: <20210301065226.11095-1-paul.elder@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v9 1/3] tests: Add IPADataSerializer test X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Test the IPADataSerializer for controls, vectors, maps, and PODs of built-in types. Signed-off-by: Paul Elder Reviewed-by: Laurent Pinchart --- Changes in v9: - convert C-style macros to C++ templates - simplify (aka remove) the custom map/vector comparators - remove dependency on the raspberrypi header, and create our own testing ControlInfoMap - reduce the size of the string for testing serializing big objects No change in v8 Changes in v7: - remove printing values of vectors/maps - simplify map and vector equality check - return immediately on the first failure Changes in v6: - no longer need to initialize rpi ControlInfoMap - no longer need to pass ControlInfoMap to the ControlList serializer Changes in v5: - use ControlInfoMap serializer instead of const ControlInfoMap serializer Changes in v4: - use RPi::controls instead RPi::Controls Changes in v3: - use re-namespaced RPi::Controls New in v2 --- .../ipa_data_serializer_test.cpp | 440 ++++++++++++++++++ test/serialization/meson.build | 1 + 2 files changed, 441 insertions(+) create mode 100644 test/serialization/ipa_data_serializer_test.cpp diff --git a/test/serialization/ipa_data_serializer_test.cpp b/test/serialization/ipa_data_serializer_test.cpp new file mode 100644 index 00000000..5e9e2bea --- /dev/null +++ b/test/serialization/ipa_data_serializer_test.cpp @@ -0,0 +1,440 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Copyright (C) 2020, Google Inc. + * + * ipa_data_serializer_test.cpp - Test serializing/deserializing with IPADataSerializer + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "libcamera/internal/device_enumerator.h" +#include "libcamera/internal/ipa_data_serializer.h" +#include "libcamera/internal/ipa_manager.h" +#include "libcamera/internal/ipa_module.h" +#include "libcamera/internal/pipeline_handler.h" +#include "libcamera/internal/thread.h" +#include "libcamera/internal/timer.h" + +#include "serialization_test.h" +#include "test.h" + +using namespace std; +using namespace libcamera; + +static const ControlInfoMap Controls = { + { &controls::AeEnable, ControlInfo(false, true) }, + { &controls::ExposureTime, ControlInfo(0, 999999) }, + { &controls::AnalogueGain, ControlInfo(1.0f, 32.0f) }, + { &controls::ColourGains, ControlInfo(0.0f, 32.0f) }, + { &controls::Brightness, ControlInfo(-1.0f, 1.0f) }, +}; + +namespace libcamera { + +static bool operator==(const ControlInfoMap &lhs, const ControlInfoMap &rhs) +{ + return SerializationTest::equals(lhs, rhs); +} + +} /* namespace libcamera */ + +template +int testPodSerdes(T in) +{ + std::vector buf; + std::vector fds; + + std::tie(buf, fds) = IPADataSerializer::serialize(in); + T out = IPADataSerializer::deserialize(buf, fds); + if (in == out) + return TestPass; + + char *name = abi::__cxa_demangle(typeid(T).name(), nullptr, + nullptr, nullptr); + cerr << "Deserialized " << name << " doesn't match original" << endl; + free(name); + return TestFail; +} + +template +int testVectorSerdes(const std::vector &in, + ControlSerializer *cs = nullptr) +{ + std::vector buf; + std::vector fds; + + std::tie(buf, fds) = IPADataSerializer>::serialize(in, cs); + std::vector out = IPADataSerializer>::deserialize(buf, fds, cs); + if (in == out) + return TestPass; + + char *name = abi::__cxa_demangle(typeid(T).name(), nullptr, + nullptr, nullptr); + cerr << "Deserialized std::vector<" << name + << "> doesn't match original" << endl; + free(name); + return TestFail; +} + +template +int testMapSerdes(const std::map &in, + ControlSerializer *cs = nullptr) +{ + std::vector buf; + std::vector fds; + + std::tie(buf, fds) = IPADataSerializer>::serialize(in, cs); + std::map out = IPADataSerializer>::deserialize(buf, fds, cs); + if (in == out) + return TestPass; + + char *nameK = abi::__cxa_demangle(typeid(K).name(), nullptr, + nullptr, nullptr); + char *nameV = abi::__cxa_demangle(typeid(V).name(), nullptr, + nullptr, nullptr); + cerr << "Deserialized std::map<" << nameK << ", " << nameV + << "> doesn't match original" << endl; + free(nameK); + free(nameV); + return TestFail; +} + +class IPADataSerializerTest : public CameraTest, public Test +{ +public: + IPADataSerializerTest() + : CameraTest("platform/vimc.0 Sensor B") + { + } + +protected: + int init() override + { + return status_; + } + + int run() override + { + int ret; + + ret = testControls(); + if (ret != TestPass) + return ret; + + ret = testVector(); + if (ret != TestPass) + return ret; + + ret = testMap(); + if (ret != TestPass) + return ret; + + ret = testPod(); + if (ret != TestPass) + return ret; + + return TestPass; + } + +private: + ControlList generateControlList(const ControlInfoMap &infoMap) + { + /* Create a control list with three controls. */ + ControlList list(infoMap); + + list.set(controls::Brightness, 0.5f); + list.set(controls::Contrast, 1.2f); + list.set(controls::Saturation, 0.2f); + + return list; + } + + int testControls() + { + ControlSerializer cs; + + const ControlInfoMap &infoMap = camera_->controls(); + ControlList list = generateControlList(infoMap); + + std::vector infoMapBuf; + std::tie(infoMapBuf, std::ignore) = + IPADataSerializer::serialize(infoMap, &cs); + + std::vector listBuf; + std::tie(listBuf, std::ignore) = + IPADataSerializer::serialize(list, &cs); + + const ControlInfoMap infoMapOut = + IPADataSerializer::deserialize(infoMapBuf, &cs); + + ControlList listOut = IPADataSerializer::deserialize(listBuf, &cs); + + if (!SerializationTest::equals(infoMap, infoMapOut)) { + cerr << "Deserialized map doesn't match original" << endl; + return TestFail; + } + + if (!SerializationTest::equals(list, listOut)) { + cerr << "Deserialized list doesn't match original" << endl; + return TestFail; + } + + return TestPass; + } + + int testVector() + { + ControlSerializer cs; + + /* + * We don't test FileDescriptor serdes because it dup()s, so we + * can't check for equality. + */ + std::vector vecUint8 = { 1, 2, 3, 4, 5, 6 }; + std::vector vecUint16 = { 1, 2, 3, 4, 5, 6 }; + std::vector vecUint32 = { 1, 2, 3, 4, 5, 6 }; + std::vector vecUint64 = { 1, 2, 3, 4, 5, 6 }; + std::vector vecInt8 = { 1, 2, 3, -4, 5, -6 }; + std::vector vecInt16 = { 1, 2, 3, -4, 5, -6 }; + std::vector vecInt32 = { 1, 2, 3, -4, 5, -6 }; + std::vector vecInt64 = { 1, 2, 3, -4, 5, -6 }; + std::vector vecFloat = { 1.1, 2.2, 3.3, -4.4, 5.5, -6.6 }; + std::vector vecDouble = { 1.1, 2.2, 3.3, -4.4, 5.5, -6.6 }; + std::vector vecBool = { true, true, false, false, true, false }; + std::vector vecString = { "foo", "bar", "baz" }; + std::vector vecControlInfoMap = { + camera_->controls(), + Controls, + }; + + std::vector buf; + std::vector fds; + + if (testVectorSerdes(vecUint8) != TestPass) + return TestFail; + + if (testVectorSerdes(vecUint16) != TestPass) + return TestFail; + + if (testVectorSerdes(vecUint32) != TestPass) + return TestFail; + + if (testVectorSerdes(vecUint64) != TestPass) + return TestFail; + + if (testVectorSerdes(vecInt8) != TestPass) + return TestFail; + + if (testVectorSerdes(vecInt16) != TestPass) + return TestFail; + + if (testVectorSerdes(vecInt32) != TestPass) + return TestFail; + + if (testVectorSerdes(vecInt64) != TestPass) + return TestFail; + + if (testVectorSerdes(vecFloat) != TestPass) + return TestFail; + + if (testVectorSerdes(vecDouble) != TestPass) + return TestFail; + + if (testVectorSerdes(vecBool) != TestPass) + return TestFail; + + if (testVectorSerdes(vecString) != TestPass) + return TestFail; + + if (testVectorSerdes(vecControlInfoMap, &cs) != TestPass) + return TestFail; + + return TestPass; + } + + int testMap() + { + ControlSerializer cs; + + /* + * Realistically, only string and integral keys. + * Test simple, complex, and nested compound value. + */ + std::map mapUintStr = + { { 101, "foo" }, { 102, "bar" }, { 103, "baz" } }; + std::map mapIntStr = + { { 101, "foo" }, { -102, "bar" }, { -103, "baz" } }; + std::map mapStrStr = + { { "a", "foo" }, { "b", "bar" }, { "c", "baz" } }; + std::map mapUintCIM = + { { 201, camera_->controls() }, { 202, Controls } }; + std::map mapIntCIM = + { { 201, camera_->controls() }, { -202, Controls } }; + std::map mapStrCIM = + { { "a", camera_->controls() }, { "b", Controls } }; + std::map> mapUintBVec = + { { 301, { 1, 2, 3 } }, { 302, { 4, 5, 6 } }, { 303, { 7, 8, 9 } } }; + std::map> mapIntBVec = + { { 301, { 1, 2, 3 } }, { -302, { 4, 5, 6} }, { -303, { 7, 8, 9 } } }; + std::map> mapStrBVec = + { { "a", { 1, 2, 3 } }, { "b", { 4, 5, 6 } }, { "c", { 7, 8, 9 } } }; + + std::vector buf; + std::vector fds; + + if (testMapSerdes(mapUintStr) != TestPass) + return TestFail; + + if (testMapSerdes(mapIntStr) != TestPass) + return TestFail; + + if (testMapSerdes(mapStrStr) != TestPass) + return TestFail; + + if (testMapSerdes(mapUintCIM, &cs) != TestPass) + return TestFail; + + if (testMapSerdes(mapIntCIM, &cs) != TestPass) + return TestFail; + + if (testMapSerdes(mapStrCIM, &cs) != TestPass) + return TestFail; + + if (testMapSerdes(mapUintBVec) != TestPass) + return TestFail; + + if (testMapSerdes(mapIntBVec) != TestPass) + return TestFail; + + if (testMapSerdes(mapStrBVec) != TestPass) + return TestFail; + + return TestPass; + } + + int testPod() + { + uint32_t u32min = numeric_limits::min(); + uint32_t u32max = numeric_limits::max(); + uint32_t u32one = 1; + int32_t i32min = numeric_limits::min(); + int32_t i32max = numeric_limits::max(); + int32_t i32one = 1; + + uint64_t u64min = numeric_limits::min(); + uint64_t u64max = numeric_limits::max(); + uint64_t u64one = 1; + int64_t i64min = numeric_limits::min(); + int64_t i64max = numeric_limits::max(); + int64_t i64one = 1; + + float flow = numeric_limits::lowest(); + float fmin = numeric_limits::min(); + float fmax = numeric_limits::max(); + float falmostOne = 1 + 1.0e-37; + double dlow = numeric_limits::lowest(); + double dmin = numeric_limits::min(); + double dmax = numeric_limits::max(); + double dalmostOne = 1 + 1.0e-307; + + bool t = true; + bool f = false; + + stringstream ss; + for (unsigned int i = 0; i < (1 << 11); i++) + ss << "0123456789"; + + string strLong = ss.str(); + string strEmpty = ""; + + std::vector buf; + std::vector fds; + + if (testPodSerdes(u32min) != TestPass) + return TestFail; + + if (testPodSerdes(u32max) != TestPass) + return TestFail; + + if (testPodSerdes(u32one) != TestPass) + return TestFail; + + if (testPodSerdes(i32min) != TestPass) + return TestFail; + + if (testPodSerdes(i32max) != TestPass) + return TestFail; + + if (testPodSerdes(i32one) != TestPass) + return TestFail; + + if (testPodSerdes(u64min) != TestPass) + return TestFail; + + if (testPodSerdes(u64max) != TestPass) + return TestFail; + + if (testPodSerdes(u64one) != TestPass) + return TestFail; + + if (testPodSerdes(i64min) != TestPass) + return TestFail; + + if (testPodSerdes(i64max) != TestPass) + return TestFail; + + if (testPodSerdes(i64one) != TestPass) + return TestFail; + + if (testPodSerdes(flow) != TestPass) + return TestFail; + + if (testPodSerdes(fmin) != TestPass) + return TestFail; + + if (testPodSerdes(fmax) != TestPass) + return TestFail; + + if (testPodSerdes(falmostOne) != TestPass) + return TestFail; + + if (testPodSerdes(dlow) != TestPass) + return TestFail; + + if (testPodSerdes(dmin) != TestPass) + return TestFail; + + if (testPodSerdes(dmax) != TestPass) + return TestFail; + + if (testPodSerdes(dalmostOne) != TestPass) + return TestFail; + + if (testPodSerdes(t) != TestPass) + return TestFail; + + if (testPodSerdes(f) != TestPass) + return TestFail; + + if (testPodSerdes(strLong) != TestPass) + return TestFail; + + if (testPodSerdes(strEmpty) != TestPass) + return TestFail; + + return TestPass; + } +}; + +TEST_REGISTER(IPADataSerializerTest) diff --git a/test/serialization/meson.build b/test/serialization/meson.build index 6fc54f6b..a4636337 100644 --- a/test/serialization/meson.build +++ b/test/serialization/meson.build @@ -2,6 +2,7 @@ serialization_tests = [ ['control_serialization', 'control_serialization.cpp'], + ['ipa_data_serializer_test', 'ipa_data_serializer_test.cpp'], ] foreach t : serialization_tests