From patchwork Mon Feb 22 08:01:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 11352 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 13B81BD1F6 for ; Mon, 22 Feb 2021 08:01:35 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B9A30689FD; Mon, 22 Feb 2021 09:01:34 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="LDQQAGK7"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A7BEC689F3 for ; Mon, 22 Feb 2021 09:01:32 +0100 (CET) Received: from pyrite.rasen.tech (unknown [IPv6:2400:4051:61:600:2c71:1b79:d06d:5032]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9DFE3344; Mon, 22 Feb 2021 09:01:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1613980892; bh=iKJu5FRh2pqTRYnDcPsrGUfyUdf/oFNxmm0dh0R2aWg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LDQQAGK79UJbCnaACFvGSdGljwVQ5iV3Uu5BpX/WKcFcJF7JPMVHsiuL6Zo9YuNW/ THYYYpmDcget6xifFp50HZq5GlWzZyJR3zNqM4cNN62r7SC8hUyyQgEGAwhKao0WZi 1TTvvhspAOO6HVUnawzwx/RNKMN115uWSwYTbp2c= From: Paul Elder To: libcamera-devel@lists.libcamera.org Date: Mon, 22 Feb 2021 17:01:11 +0900 Message-Id: <20210222080112.72521-2-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210222080112.72521-1-paul.elder@ideasonboard.com> References: <20210222080112.72521-1-paul.elder@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 1/2] libcamera: camera_sensor: Print warning when orientation is unknown X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Print a warning when the orientation of a sensor is unknown. The location property is still defaulted to external. Signed-off-by: Paul Elder Reviewed-by: Kieran Bingham --- Changes in v2: - expand the warning message --- src/libcamera/camera_sensor.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp index c9e8d49b..d7785f63 100644 --- a/src/libcamera/camera_sensor.cpp +++ b/src/libcamera/camera_sensor.cpp @@ -446,6 +446,12 @@ int CameraSensor::initProperties() break; } } else { + LOG(CameraSensor, Warning) + << "Failed to retrieve the camera location, setting to External"; + LOG(CameraSensor, Warning) + << "The sensor kernel driver needs to be fixed"; + LOG(CameraSensor, Warning) + << "See Documentation/sensor_driver_requirements.rst in the libcamera sources for more information"; propertyValue = properties::CameraLocationExternal; } properties_.set(properties::Location, propertyValue);