From patchwork Mon Feb 15 10:12:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 11298 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 46B17BD162 for ; Mon, 15 Feb 2021 10:12:24 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 16C2D637C9; Mon, 15 Feb 2021 11:12:24 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="HDazMhqr"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6D9B86375F for ; Mon, 15 Feb 2021 11:12:22 +0100 (CET) Received: from pyrite.rasen.tech (unknown [IPv6:2400:4051:61:600:2c71:1b79:d06d:5032]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 052A1743; Mon, 15 Feb 2021 11:12:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1613383942; bh=Lepowur9CMGnSW/wO1rxCZCbniYZrEQq0T2N5GikfEE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HDazMhqr/ttvuIUSuAE4aq1YiSNmJ1Ct2izi5mvoh7B0SjY5zBiPc/xjvVvzSFG4d WDcbBzZRw29tAQTwvhpJOjbPaz1RqI7Q/px4KIRddxbqjr677zVmTlDorqCDhNf+QU 8ss1+6IDy1dc5S/owoasiRKZIawrp3J7y4DJOvTQ= From: Paul Elder To: libcamera-devel@lists.libcamera.org Date: Mon, 15 Feb 2021 19:12:00 +0900 Message-Id: <20210215101200.149457-5-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210215101200.149457-1-paul.elder@ideasonboard.com> References: <20210215101200.149457-1-paul.elder@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 4/4] cam: Print unknown location X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Now that we default the camera sensor location to Unknown, print that the location is unknown in cam. We report the location as unknown instead of defaulting to something else since cam is a test tool. Signed-off-by: Paul Elder --- Changes in v3: - report the location as unknown New in v2 --- src/cam/main.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/cam/main.cpp b/src/cam/main.cpp index e01be63a..14f12e9d 100644 --- a/src/cam/main.cpp +++ b/src/cam/main.cpp @@ -379,7 +379,8 @@ std::string const CamApp::cameraName(const Camera *camera) const ControlList &props = camera->properties(); std::string name; - switch (props.get(properties::Location)) { + int location = props.get(properties::Location); + switch (location) { case properties::CameraLocationFront: name = "Internal front camera"; break; @@ -387,7 +388,10 @@ std::string const CamApp::cameraName(const Camera *camera) name = "Internal back camera"; break; case properties::CameraLocationExternal: - name = "External camera"; + case properties::CameraLocationUnknown: + name = location == properties::CameraLocationExternal ? + "External camera" : + "Unknown Location"; if (props.contains(properties::Model)) name += " '" + props.get(properties::Model) + "'"; break;