From patchwork Mon Feb 15 10:11:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 11295 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 28B82BD162 for ; Mon, 15 Feb 2021 10:12:17 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id EACD2637C4; Mon, 15 Feb 2021 11:12:16 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="QDVwwx+w"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 03AF16375F for ; Mon, 15 Feb 2021 11:12:15 +0100 (CET) Received: from pyrite.rasen.tech (unknown [IPv6:2400:4051:61:600:2c71:1b79:d06d:5032]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 987FB743; Mon, 15 Feb 2021 11:12:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1613383934; bh=31tnoUZ4J0/jdeQvMwQ2RoWnfPl5feEqhFD72m2mSvc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QDVwwx+wpwTS4aWTRSHbkhITfOxAa4Q7JDGPfUAM7jjFVYtS+MumqIWL9qD82Uiq/ nxINW1BIIffGw99VN4S7z7UL7FZNuvCGam+DEqC5jWwZMtjaTkv3vXw5BLQ70FTpq7 nVAqgNaQXqldi3SDMuCH0NrLAiqwKi43D3hFLW1Y= From: Paul Elder To: libcamera-devel@lists.libcamera.org Date: Mon, 15 Feb 2021 19:11:57 +0900 Message-Id: <20210215101200.149457-2-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210215101200.149457-1-paul.elder@ideasonboard.com> References: <20210215101200.149457-1-paul.elder@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 1/4] libcamera: properties: Add Unknown value to camera Location X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" If a camera's location is unknown, it should be set so, and not defaulted to another location. Add such a value to the Location property enum. Signed-off-by: Paul Elder Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart Reviewed-by: Jacopo Mondi --- No change in v3 Changes in v2: - Unknown is now 0, the rest are incremented by 1 --- src/libcamera/property_ids.yaml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml index 104e9aaf..fd17bf0c 100644 --- a/src/libcamera/property_ids.yaml +++ b/src/libcamera/property_ids.yaml @@ -10,18 +10,22 @@ controls: description: | Camera mounting location enum: - - name: CameraLocationFront + - name: CameraLocationUnknown value: 0 + description: | + The camera location is unknown + - name: CameraLocationFront + value: 1 description: | The camera is mounted on the front side of the device, facing the user - name: CameraLocationBack - value: 1 + value: 2 description: | The camera is mounted on the back side of the device, facing away from the user - name: CameraLocationExternal - value: 2 + value: 3 description: | The camera is attached to the device in a way that allows it to be moved freely