From patchwork Fri Feb 12 13:18:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 11259 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4EB05BD162 for ; Fri, 12 Feb 2021 13:18:58 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D7D786377C; Fri, 12 Feb 2021 14:18:57 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="N+yB6RqM"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C624563772 for ; Fri, 12 Feb 2021 14:18:55 +0100 (CET) Received: from localhost.localdomain (unknown [IPv6:2a01:e0a:169:7140:4c8b:e37:8e78:b4b6]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 479BD8B5; Fri, 12 Feb 2021 14:18:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1613135935; bh=KuKx2Gj42rvP9V2/2ogu5Xo2K8yZucBa4w3T6sP+qwE=; h=From:To:Cc:Subject:Date:From; b=N+yB6RqMPb38OEh6/+49qW3jH3ZIyP0PmkYIP0581bCCBN0PcbV2+V2bWs9eKWRuN RFRisjHKnfI94SHA/EYs0HPbZc/LDdXRhhPIRzwBrzvfmgVWdaQk5NbqrBJhzlHnuq z1hELhAouXUDztRP/U7P4usfR3G1yCbux4RkcErc= From: Jean-Michel Hautbois To: libcamera-devel@lists.libcamera.org Date: Fri, 12 Feb 2021 14:18:51 +0100 Message-Id: <20210212131851.22059-1-jeanmichel.hautbois@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2] libcamera: ipu3: set V4L2_CID_INTEL_IPU3_MODE X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" In order to get the stats back, the imgu subdev needs to have the V4L2_CID_INTEL_IPU3_MODE control set. Set it to video mode by default to get the stats at each frame. Signed-off-by: Jean-Michel Hautbois Reviewed-by: Jacopo Mondi Reviewed-by: Laurent Pinchart --- src/libcamera/pipeline/ipu3/ipu3.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index 61f7bf43..6957e3a9 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -551,9 +551,13 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c) /* Apply the "pipe_mode" control to the ImgU subdevice. */ ControlList ctrls(imgu->imgu_->controls()); + /* + * \todo Set the ImgU pipe mode to 'Video' unconditionally to have statistics + * generated and re-consider if 'Still Capture' should be used for + * high quality RAW capture operations that do not involve the IPA. + */ ctrls.set(V4L2_CID_IPU3_PIPE_MODE, - static_cast(vfCfg ? IPU3PipeModeVideo : - IPU3PipeModeStillCapture)); + static_cast(IPU3PipeModeVideo)); ret = imgu->imgu_->setControls(&ctrls); if (ret) { LOG(IPU3, Error) << "Unable to set pipe_mode control";