From patchwork Fri Feb 12 11:33:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 11255 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D47AEBD160 for ; Fri, 12 Feb 2021 11:37:37 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A619563786; Fri, 12 Feb 2021 12:37:37 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="gnoGi5a1"; dkim-atps=neutral Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 76DF863778 for ; Fri, 12 Feb 2021 12:37:33 +0100 (CET) Received: by mail-wr1-x435.google.com with SMTP id g10so7513500wrx.1 for ; Fri, 12 Feb 2021 03:37:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8Js2N/PMpza7AgEjn/VI402ahkH5WnlAn0p4sgmqgn8=; b=gnoGi5a1qxMi3Pwdfs+cgmlUdQHKlZzw3Bb6knyUJr1cQW+dOQ1QrgcZ0slAjhoL4I 3dv+gA9LNDq24H91GRvRbOjYzUPYQgx3LVZDLd2GtUpCeNq6jhEDcn2I0g3Xxf8MQk5V yQR/Dx/GiiF2/2kvIKrVjPeq6WIEKoMUv23pILIUYni1DgSR7gqH1zHlm7N2c1NarGgU huJZjIpzlWbODKxmkghCfVDyQwv2lzoQkR6hl5TtKRedsQl/iVmjghkRNmf52BSEFRT7 Vq398KeuUe4BOECniiHGC5MUc39DB4gwp/YrgZB2KY1rbt1rOg5NqYQy54f0EJUrNU0r BTCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8Js2N/PMpza7AgEjn/VI402ahkH5WnlAn0p4sgmqgn8=; b=qjNsAVkvn4i/lw+XrobXbiQKiqtIsoa+Q8Mn92YGXNFavxYrUErPLK+VJzRxlmYy1Q VwciDnq0NKGmV67GcNDvi0vf4Xt4/E1p6J8bQkP+4d4ymDdE4KeoHIpXfGEFYZrsS9Em x3N9fafaP+aY9TngL2/QTlc9SkT4N6/Xz+NU4r8+EwPR5KTibVaT5OrNIv0yhXrbT1id 9pdXVNy7NQC6bNt1tbGJdxcs57jbuTcKNl3/iUkXNhrR5CkmNkC96/hT67UeRDqyeO7P Jc07SzjUksB7xiZo9fCJc0z42VS0+tGE4XymiS4NxO3HbQBMLT7Ct93U0Ag8TM6gLuZ5 M9ig== X-Gm-Message-State: AOAM530jMfz4WQnD9Z8qD64i/2npAH1wLuAD93SgaffHaH0zFejX1TsM 0dpqmyjpA8Y9G0SKOqOlV6lCoHFwq7bYmOvI X-Google-Smtp-Source: ABdhPJyOY5l2R72/GVmpwzxIepGg1hNVLG8ajdQRRE5zW4ODK8dtYDBZ1Wpdhh3Oja5mIG2fWekUFg== X-Received: by 2002:adf:82b3:: with SMTP id 48mr2856968wrc.22.1613129852672; Fri, 12 Feb 2021 03:37:32 -0800 (PST) Received: from naush-laptop.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id v5sm10005020wro.71.2021.02.12.03.37.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Feb 2021 03:37:32 -0800 (PST) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Fri, 12 Feb 2021 11:33:09 +0000 Message-Id: <20210212113312.239076-3-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210212113312.239076-1-naush@raspberrypi.com> References: <20210212113312.239076-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 2/5] utils: raspberrypi: Add a DelayedControls log parser X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This script will parse log output from the DelayedControls helper, when enabled with: LIBCAMERA_LOG_LEVELS=DelayedControls:0 It tabulates all control queuing/writing/getting per frame and warns about potential issues related to frame delays not being account for, or writes that are lagging behind or missed. Run with the following command: python3 ./delayedctrls_parse.py Signed-off-by: Naushir Patuck --- utils/raspberrypi/delayedctrls_parse.py | 82 +++++++++++++++++++++++++ 1 file changed, 82 insertions(+) create mode 100644 utils/raspberrypi/delayedctrls_parse.py diff --git a/utils/raspberrypi/delayedctrls_parse.py b/utils/raspberrypi/delayedctrls_parse.py new file mode 100644 index 000000000000..2e1c40d8b896 --- /dev/null +++ b/utils/raspberrypi/delayedctrls_parse.py @@ -0,0 +1,82 @@ +import re +import sys +import os + +if len(sys.argv) != 2: + print("Usage: {} ".format(sys.argv[0])) + sys.exit() + +infile = sys.argv[1] +insplit = os.path.splitext(infile) +outfile = insplit[0] + '_parsed' + insplit[1] + +frame_re = re.compile('frame (\d+) started') + +delays = {'Analogue Gain': 1, 'Exposure': 2, 'Vertical Blanking': 2} +ctrl_action = {'Write': {}, 'Get': {}, 'Queue': {}} +ctrl_re = {'Write': re.compile('Setting (.*?) to (\d+) at index (\d+)'), + 'Get': re.compile('Reading (.*?) to (\d+) at index (\d+)'), + 'Queue': re.compile('Queuing (.*?) to (\d+) at index (\d+)')} + +frame_num = -1 + +max_delay = 0 +for k, d in delays.items(): + if max_delay < d: + max_delay = d + +with open(infile) as f: + lines = f.readlines() + +for line in lines: + r = frame_re.search(line) + if r: + frame_num = int(r.group(1)) + + for (key, re) in ctrl_re.items(): + r = re.search(line) + if r: + ctrl_action[key][(frame_num, r.group(1))] = (r.group(2), r.group(3)) + +with open(outfile, 'wt') as f: + f.write('{:<10}{:<15}{:<12}{:<18}{}\n'.format('Frame', 'Action', 'Gain', 'Exposure', 'Vblank')) + for frame in range(0, frame_num + 1): + for (k, a) in ctrl_action.items(): + str = '{:<10}{:<10}'.format(frame, k) + + for c in delays.keys(): + # Tabulate all results + str += '{:>5} {:<10}'.format(a[(frame, c)][0] if (frame, c) in a.keys() else '---', + '[' + (a[(frame, c)][1] if (frame, c) in a.keys() else '-') + ']') + + f.write(str.strip() + '\n') + +for frame in range(0, frame_num + 1): + # Test the write -> get matches the set delay. + if (frame, c) in ctrl_action['Write'].keys(): + set_value = ctrl_action['Write'][(frame, c)][0] + delay_frame = frame + delays[c] + if (delay_frame <= frame_num): + if (delay_frame, c) in ctrl_action['Get']: + get_value = ctrl_action['Get'][(delay_frame, c)][0] + if get_value != set_value: + print('Error: {} written at frame {} to value {} != {} at frame {}' + .format(c, frame, set_value, get_value, delay_frame)) + else: + print('Error: {} written at frame {} to value {} did not get logged on frame {} - dropped frame?' + .format(c, frame, set_value, delay_frame)) + + # Test the queue -> write matches the set delay. + if (frame, c) in ctrl_action['Queue'].keys(): + set_value = ctrl_action['Queue'][(frame, c)][0] + delay_frame = frame + max_delay - delays[c] + 1 + if (delay_frame <= frame_num): + if (delay_frame, c) in ctrl_action['Write']: + write_value = ctrl_action['Write'][(delay_frame, c)][0] + if write_value != set_value: + print('Info: {} queued at frame {} to value {} != {} written at frame {}' + ' - lagging behind or double queue on a single frame!' + .format(c, frame, set_value, write_value, delay_frame)) + else: + print('Error: {} queued at frame {} to value {} did not get logged on frame {} - dropped frame?' + .format(c, frame, set_value, delay_frame))