From patchwork Tue Feb 9 15:03:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 11204 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 750A0BD162 for ; Tue, 9 Feb 2021 15:03:39 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 053F761629; Tue, 9 Feb 2021 16:03:39 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="BfAwiacI"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B04A560D16 for ; Tue, 9 Feb 2021 16:03:37 +0100 (CET) Received: from localhost.localdomain (unknown [IPv6:2a01:e0a:169:7140:4d26:9423:a9d1:8c4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 31EAD9AA; Tue, 9 Feb 2021 16:03:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1612883017; bh=05mC+v5P8QDC1RzePSYjHtts1afgFlBwyft0+JETr8g=; h=From:To:Cc:Subject:Date:From; b=BfAwiacIafIHAUl4KdJXT1x6GFpa7CUP9nSBn11zg9TA0U93hanGSpHp/PA5dPGlS IWXwrUuchQSkqc1QAS02bytMTxr5XWvKRw6oH6FvzIQvJPc47gMn9ii+gsjqr+iEzK aab0dgkLNQjbVoGz9PG8ensHNMdT7xNMFHFpFoZE= From: Jean-Michel Hautbois To: libcamera-devel@lists.libcamera.org Date: Tue, 9 Feb 2021 16:03:35 +0100 Message-Id: <20210209150335.26773-1-jeanmichel.hautbois@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] ipa: ipu3: Don't call SetControls for each frame X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Setting a default EXPOSURE and ANALOGUE_GAIN makes sense for the first frame but there is no need to force it for all frames. It will be called later by the 3A algorithms. Signed-off-by: Jean-Michel Hautbois Reviewed-by: Kieran Bingham --- src/ipa/ipu3/ipu3.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp index b11b03ef..ae7e8c0b 100644 --- a/src/ipa/ipu3/ipu3.cpp +++ b/src/ipa/ipu3/ipu3.cpp @@ -188,9 +188,6 @@ void IPAIPU3::fillParams(unsigned int frame, ipu3_uapi_params *params) op.operation = IPU3_IPA_ACTION_PARAM_FILLED; queueFrameAction.emit(frame, op); - - /* \todo Calculate new values for exposure_ and gain_. */ - setControls(frame); } void IPAIPU3::parseStatistics(unsigned int frame,