From patchwork Fri Apr 26 16:06:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 1117 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1BE2960E9A for ; Fri, 26 Apr 2019 18:06:30 +0200 (CEST) Received: from pendragon.station (net-37-182-44-227.cust.vodafonedsl.it [37.182.44.227]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B459E5F for ; Fri, 26 Apr 2019 18:06:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1556294789; bh=sXLTWQ/b0bCSTkxvciLojZGWnB/oIGf01B4o1rPhs2A=; h=From:To:Subject:Date:From; b=V5KtKTUMgip+VFOEqBe9PGfxwTf8rOu9qmfQJueX2DYNQGITEqY/qwk6P7tps+J2s tESeTLcymwEfvpr6bio360mbc6nagvfQ6/rkq5D+BEuoh7Ndiw3G+aYp7MsScNz+JA h83BgyEP9i1mRjhcaVkSwEn2VYpx8plRhIHQcK7E= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Fri, 26 Apr 2019 19:06:15 +0300 Message-Id: <20190426160615.22309-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: Remove outdated \todo comments X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Apr 2019 16:06:30 -0000 Some \todo comments are outdated and refer to tasks that have been completed. Remove them. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- src/libcamera/camera_manager.cpp | 3 --- src/libcamera/device_enumerator.cpp | 1 - src/libcamera/v4l2_device.cpp | 6 ++---- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp index 58d3b0ddb8bb..40a39bd2a6d9 100644 --- a/src/libcamera/camera_manager.cpp +++ b/src/libcamera/camera_manager.cpp @@ -50,9 +50,6 @@ LOG_DEFINE_CATEGORY(Camera) * references it held to cameras, the camera manager can be stopped with * stop(). * - * \todo Add ability to add and remove media devices based on hot-(un)plug - * events coming from the device enumerator. - * * \todo Add interface to register a notification callback to the user to be * able to inform it new cameras have been hot-plugged or cameras have been * removed due to hot-unplug. diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp index f3f26d98b65e..49467546bab8 100644 --- a/src/libcamera/device_enumerator.cpp +++ b/src/libcamera/device_enumerator.cpp @@ -40,7 +40,6 @@ * expressed in a DeviceMatch object. * * \todo Add sysfs based device enumerator. - * \todo Add support for hot-plug and hot-unplug. */ namespace libcamera { diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp index cfdce4813da4..a6e9ca247828 100644 --- a/src/libcamera/v4l2_device.cpp +++ b/src/libcamera/v4l2_device.cpp @@ -750,9 +750,6 @@ int V4L2Device::releaseBuffers() * processed by the device. Once the device has finished processing the buffer, * it will be available for dequeue. * - * \todo Support output devices (bytesused, ...) - * \todo Support imported buffers (dmabuf fd) - * * \return 0 on success or a negative error code otherwise */ int V4L2Device::queueBuffer(Buffer *buffer) @@ -904,7 +901,8 @@ int V4L2Device::streamOn() /** * \brief Stop the video stream * - * \todo Ensure completion notifications are sent for all queued buffers + * Buffers that are still queued when the video stream is stopped are + * implicitly dequeued, but no bufferReady signal is emitted for them. * * \return 0 on success or a negative error code otherwise */