From patchwork Thu Feb 4 09:34:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 11135 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 90604BD162 for ; Thu, 4 Feb 2021 09:35:09 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5CE1961429; Thu, 4 Feb 2021 10:35:09 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="tYGj8P8X"; dkim-atps=neutral Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DF02961404 for ; Thu, 4 Feb 2021 10:35:05 +0100 (CET) Received: by mail-wr1-x429.google.com with SMTP id g10so2700777wrx.1 for ; Thu, 04 Feb 2021 01:35:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pP7sGJGC3/Dlj6wlhh7yuZ9LtQ3CKVVkcL3Zmsk3Bd0=; b=tYGj8P8XP8kSfiWuBJzozd0Fu6aM8rxqfuu9RAMQ3GVQil+6TDphOFy6RHBdBkMl0n IuLqGOu0XLtFZvHVqM3aGnVKs+Oe9lrJJOX2+rG3Nbb8xekp54i//K9XGxg6C5gdQ0Ju do5MKZ7fRwAD4f7YBmwVSqzwe8ItxxllzJVK/tNeo1Lj52zy+Y1vTZdzYKOnyZo9mUoo t1Bhdz6LB7KITeoARZQRLIKv/L+E3t0nJlMR7UB1LYPM5w6BlYUlRfeOFvZeJXorQSzu sV7fqWzmMQKOH2pQm07Jklv1XxIDMxb+MmaKo/JPYk9/eHHCXP+plsgC2wmmk40dyrgY d4rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pP7sGJGC3/Dlj6wlhh7yuZ9LtQ3CKVVkcL3Zmsk3Bd0=; b=Fj+vZs1ElWIXuUtRiL+meHQT2ygWQT7EU03+hZha+iBMeBRaKX1cV+rgbih37GxtwP 2osQDcwa6iwfye35DZRZVGWCEvvdyBpEeMpQ3jgm0qF+Aqdh6wPxTKoXVyGI7lnLaMUx GNRKQpwWgfjzFYQ9fJB2H895uPRiDPi7MNZBVP54BsxJ4o6MwdE3spNUxtBTcIRYwOZN DHBHLRZovVLOpzwo4x+y9v9Xd1PzQRWLYiaUI5uxDQrXJpMnHyblg6kWLKvU2Q8eopzr 0caKEzP9CijRZ5FVrHBjVt6Y6KtCLHn9OsSt1v0kbuZBtf8QeTLtS1CXB+8VKCUw2HdT aN3g== X-Gm-Message-State: AOAM532Cw5btRRlT7w9Q62OMigIVBHBfFXMsZ2MPWc19H1+TIuDKwVto c1pUC7NxAlPHyyVilQr2YV2RHe9fQBcwFEH6 X-Google-Smtp-Source: ABdhPJzAGf8vcD1OXOO+IfSnyKQzCJ3KeLeibnREJTLfh0256x7k84BrqSyEx13J00sbM5K1D6NEdA== X-Received: by 2002:adf:fc88:: with SMTP id g8mr8015694wrr.259.1612431305207; Thu, 04 Feb 2021 01:35:05 -0800 (PST) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id g16sm5280580wmi.30.2021.02.04.01.35.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 01:35:04 -0800 (PST) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Thu, 4 Feb 2021 09:34:55 +0000 Message-Id: <20210204093457.6879-6-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210204093457.6879-1-david.plowman@raspberrypi.com> References: <20210204093457.6879-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 5/7] ipa: raspberrypi: noise: Remove unnecessary atomic variable X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" mode_factor_ does not need to be atomic - it is set by SwitchMode() which runs synchronously. Signed-off-by: David Plowman Reviewed-by: Laurent Pinchart --- src/ipa/raspberrypi/controller/rpi/noise.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/raspberrypi/controller/rpi/noise.hpp b/src/ipa/raspberrypi/controller/rpi/noise.hpp index 6f6e0be9..1c9de5c8 100644 --- a/src/ipa/raspberrypi/controller/rpi/noise.hpp +++ b/src/ipa/raspberrypi/controller/rpi/noise.hpp @@ -26,7 +26,7 @@ private: // the noise profile for analogue gain of 1.0 double reference_constant_; double reference_slope_; - std::atomic mode_factor_; + double mode_factor_; }; } // namespace RPiController