From patchwork Fri Apr 26 15:01:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 1107 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BE12D60E9A for ; Fri, 26 Apr 2019 17:02:09 +0200 (CEST) Received: from pendragon.station (net-37-182-44-227.cust.vodafonedsl.it [37.182.44.227]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 53758337 for ; Fri, 26 Apr 2019 17:02:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1556290929; bh=vOFvJ00xOx/+CxLYLuN5oZBPNBjxDDzy+HvXyxArXYE=; h=From:To:Subject:Date:In-Reply-To:References:From; b=Ee+SZmI+k24I/qMzfETIH0elRa9uDEYIoPdujaHXsowSKxdpFHS0s/8dHal+e4DEv THi4XU/zTjeig/XFKG36fLdQo7UaG5f8bP1TYHotCrpONmr+9v7s/Z8p6PBaUlxleS ixp3TH6QGDIgIPr+1d0RTk8zZfaT4Auj3VzSNUUc= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Fri, 26 Apr 2019 18:01:48 +0300 Message-Id: <20190426150155.18652-2-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190426150155.18652-1-laurent.pinchart@ideasonboard.com> References: <20190426150155.18652-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/8] libcamera: Correct struct forward declarations X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Apr 2019 15:02:10 -0000 Several structures are forward-declarated as classes. Fix this by using the struct keyword where appropriate, or removing the forward declaration when not needed. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- include/libcamera/camera.h | 3 ++- src/libcamera/include/camera_sensor.h | 3 ++- src/libcamera/include/pipeline_handler.h | 1 - 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h index b2dafda342fe..777b7e4d48b8 100644 --- a/include/libcamera/camera.h +++ b/include/libcamera/camera.h @@ -21,9 +21,10 @@ class Buffer; class PipelineHandler; class Request; class Stream; -class StreamConfiguration; class StreamUsage; +struct StreamConfiguration; + class CameraConfiguration { public: diff --git a/src/libcamera/include/camera_sensor.h b/src/libcamera/include/camera_sensor.h index 7f2f906be8df..b823480241a7 100644 --- a/src/libcamera/include/camera_sensor.h +++ b/src/libcamera/include/camera_sensor.h @@ -18,7 +18,8 @@ namespace libcamera { class MediaEntity; class V4L2Subdevice; -class V4L2SubdeviceFormat; + +struct V4L2SubdeviceFormat; class CameraSensor : protected Loggable { diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h index c3f7d4c29205..5830e53108fa 100644 --- a/src/libcamera/include/pipeline_handler.h +++ b/src/libcamera/include/pipeline_handler.h @@ -26,7 +26,6 @@ class MediaDevice; class PipelineHandler; class Request; class Stream; -class StreamConfiguration; class StreamUsage; class CameraData