From patchwork Thu Jan 21 11:58:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 10923 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 710D2C0F2A for ; Thu, 21 Jan 2021 11:58:57 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3CFFE681EE; Thu, 21 Jan 2021 12:58:57 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="dNRTyvnk"; dkim-atps=neutral Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 15BFE681C8 for ; Thu, 21 Jan 2021 12:58:55 +0100 (CET) Received: by mail-wm1-x32d.google.com with SMTP id j18so1213131wmi.3 for ; Thu, 21 Jan 2021 03:58:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RlcCs85RsvREHCFk25gd9h0IFdCVRIaWFJ7wNCTORis=; b=dNRTyvnkewf0xKlhHFGRWRF5nP24Tj31GLFtltRv4HnYZbUXqbERgC6Xx+G6JiOoQu Nwvk+C+PUx1LdCWcC9dQBq9HoOWlrGxiDcg1pVyugTCC9zpOD4E6NDitVZS7SEsRZxeS NMhoYYDiwuce0Ap7knedpA9H3EGuN/MlDxbK3MNz1NTGFgDz06rWpqE7rbFNdgOTSesv JZt90ZVwCEp6nr5BuA2UootFWhLi9rlxNwNovc+ik2ll5WtE8zOq0lfIsptqnjkbhS5i yD2FzvNSXv5YbliIXNdhdvACfEnrkYMgTDhFIjXHZzc4Tm/yxxhOG4NGg6VUPQG+CSen sREA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RlcCs85RsvREHCFk25gd9h0IFdCVRIaWFJ7wNCTORis=; b=emSLpz/fX+r65O6+xXAjAEAbT/Ro/vONSSO+ndhgHv92carpuzrHDBhYNkKkT2rdok grGw4JIDeYPfL4o1+OI0TMUsJDVCX16P8AJQvz/PD8sDiA0FKxmxKfiDd7xeiLEg9kor NP6YU2x4l/Fr01m+5I1mAku1zo/6tHQkikPivyo5fgt+yXk08IE/u+V9AKe2EEnueyu7 uFrhlUs7pIyPjYq6kgsJec6qj4Shm6IwS74HcnWvLnnk/0DU/tMnpNRSK5cEWtT+t/R2 kl4Cdamk3FIRfKrbFO3cHZfxDUtNcRgZOqQyhAFOgWNE/STpsefaehTjTwEynm1E9QhI nghw== X-Gm-Message-State: AOAM532JfgIMJ/x32fpJ/6b8Zgl1ImYJdX4569OHdERhM1M+QyO8cxtF ovjcCf6XxNywZ4UdDTTFAzK1vK8+LLWp+g== X-Google-Smtp-Source: ABdhPJxmM6NlXRB8fTThFLyqLrZ/ENLHAQdsvh0qbShrpx2bp+REwMVMiKwpZ4W6G8rCJmR87fl0cw== X-Received: by 2002:a05:600c:2a47:: with SMTP id x7mr8529219wme.145.1611230334617; Thu, 21 Jan 2021 03:58:54 -0800 (PST) Received: from naushir-VirtualBox.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id h13sm8044930wrm.28.2021.01.21.03.58.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 03:58:53 -0800 (PST) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Thu, 21 Jan 2021 11:58:46 +0000 Message-Id: <20210121115849.682130-2-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121115849.682130-1-naush@raspberrypi.com> References: <20210121115849.682130-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/4] raspberrypi: Add the correct integer const postfix for FrameDurations X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" At startup, ControlInfoMap::generateIdmap() threw a log message warning that the controls::FrameDurations had a type mismatch based on the min/max values provided in libcamera::RPi::Controls initialiser. Fix this warning by adding and explicit int64_t postfix to the const values for min and max. Signed-off-by: Naushir Patuck Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- include/libcamera/ipa/raspberrypi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h index 1de36039cee0..8e704d922ce6 100644 --- a/include/libcamera/ipa/raspberrypi.h +++ b/include/libcamera/ipa/raspberrypi.h @@ -65,7 +65,7 @@ static const ControlInfoMap Controls = { { &controls::Sharpness, ControlInfo(0.0f, 16.0f, 1.0f) }, { &controls::ColourCorrectionMatrix, ControlInfo(-16.0f, 16.0f) }, { &controls::ScalerCrop, ControlInfo(Rectangle{}, Rectangle(65535, 65535, 65535, 65535), Rectangle{}) }, - { &controls::FrameDurations, ControlInfo(1000, 1000000000) }, + { &controls::FrameDurations, ControlInfo(INT64_C(1000), INT64_C(1000000000)) }, }; } /* namespace RPi */