From patchwork Wed Jan 6 10:06:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 10828 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id AB8E4C0F1D for ; Wed, 6 Jan 2021 10:07:06 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 00A6A630BB; Wed, 6 Jan 2021 11:07:06 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="BAeHGZ9d"; dkim-atps=neutral Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3E0C062007 for ; Wed, 6 Jan 2021 11:07:05 +0100 (CET) Received: by mail-wr1-x42e.google.com with SMTP id y17so1855342wrr.10 for ; Wed, 06 Jan 2021 02:07:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gsim8+we0stMr/1j7X70QSAiPz8/X0X0Lc4hTx2MvLE=; b=BAeHGZ9daKFw2DTCCgkntoChKu8Pdrh/p4y8o3CcwUMZUXZmrCyeNmjzCbb7BIedWl WJMikmOncaSJCvPlJP6CrJu/7cDd5IR3T75qBhax7mR+iv27guI1/M6UygP0wFLcI7yn WHDghaQ5azmpgqsAL4JLNKXrlqXnzBhdpznUYNwd3ZO+J3M4tDWRoKoTgiQWtHgezoXn vagrsxmqTRQOj+IWLfDf1fXUnIvSrpkOY/xuqG0mWijjvduEJtCO1U8b3C4RT88bUAQ4 fpz7MQOx0vssup4aeawHyKljKRJQ5jK15d44eEGili+vzg444X7PaNKSa39EVFlu0tyM XlNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gsim8+we0stMr/1j7X70QSAiPz8/X0X0Lc4hTx2MvLE=; b=IZAE2I5gtlVc+TGWNcoHhhoCxJwAkONfkLisD1ZkW8paKJEPr79ZdXCyRVPGZO5v8/ 8yjbwTtWbhPLGwdUH6dz9ymmCvv+aiK3XRA1IXRDcoXzeyLybepPFOaWvYYHVwXAVXiS GyaxROgkoI0EFJ4xJFB4+rih8+lZWOhBdFY4qHWkQqaIBupSvHxW05bFyyBQ2yrC4dOo ucDSZCTxZuRm4Qi9uGOe8KZYDTmoDMHu/1/I11Pogkik2LXVFEX4QeoUyAyLHShHQPtI nNwTSGP5rWjxDnbF9hVaU4QKUV9VlwpwoZViYnCMoJR+nREJSmDjO5o1Kzt59grv2Qe9 x3yg== X-Gm-Message-State: AOAM531zXQNuOqZw7qMsI9ZLcpbDwculUKpVHgPXf012srfpAqnuHAq/ U1Y+CiUFCsVARsWb0q2kAok8DwLjm1BCzA== X-Google-Smtp-Source: ABdhPJyUsBqCowal9i612gwMwkcepqrpXEIYtLd700jYyAMjzdNqLgTHJ6dvOZx4yxq1oQx9OWDtDQ== X-Received: by 2002:a5d:604a:: with SMTP id j10mr3602728wrt.290.1609927624717; Wed, 06 Jan 2021 02:07:04 -0800 (PST) Received: from naushir-VirtualBox.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id m21sm2382381wml.13.2021.01.06.02.07.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jan 2021 02:07:03 -0800 (PST) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Wed, 6 Jan 2021 10:06:57 +0000 Message-Id: <20210106100659.8363-2-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210106100659.8363-1-naush@raspberrypi.com> References: <20210106100659.8363-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v11 1/3] libcamera: controls: Add frame duration control X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add an int64_t array control (controls::FrameDurations) to specify the minimum and maximum (in that order) frame duration to be used by the camera sensor. Signed-off-by: Naushir Patuck Reviewed-by: David Plowman Tested-by: David Plowman Reviewed-by: Jacopo Mondi --- src/libcamera/control_ids.yaml | 38 ++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml index 6d6f0fee..d1240beb 100644 --- a/src/libcamera/control_ids.yaml +++ b/src/libcamera/control_ids.yaml @@ -306,6 +306,44 @@ controls: maximum valid value is given by the properties::ScalerCropMaximum property, and the two can be used to implement digital zoom. + - FrameDurations: + type: int64_t + description: | + The minimum and maximum (in that order) frame duration, + expressed in micro-seconds. + + When provided by applications, the control specifies the sensor frame + duration interval the pipeline has to use. This limits the largest + exposure time the sensor can use. For example, if a maximum frame + duration of 33ms is requested (corresponding to 30 frames per second), + the sensor will not be able to raise the exposure time above 33ms. + A fixed frame duration is achieved by setting the minimum and maximum + values to be the same. Setting both values to 0 reverts to using the + IPA provided defaults. + + The maximum frame duration provides the absolute limit to the shutter + speed computed by the AE algorithm and it overrides any exposure mode + setting specified with controls::AeExposureMode. Similarly, when a + manual exposure time is set through controls::ExposureTime, it also + gets clipped to the limits set by this control. When reported in + metadata, the control expresses the minimum and maximum frame + durations used after being clipped to these limits. + + \sa AeExposureMode + \sa ExposureTime + + \todo Refer to the frame duration limits property to describe how + application-provided values gets clipped and reset. + + \todo Define how to calculate the capture frame rate by + defining controls to report additional delays introduced by + the capture pipeline or post-processing stages (ie JPEG + conversion, frame scaling). + + \todo Provide an explicit definition of default control values, for + this and all other controls. + size: [2] + # ---------------------------------------------------------------------------- # Draft controls section