From patchwork Mon Dec 28 16:40:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 10755 X-Patchwork-Delegate: jacopo@jmondi.org Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CB201C0F1C for ; Mon, 28 Dec 2020 16:39:59 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 808F362007; Mon, 28 Dec 2020 17:39:59 +0100 (CET) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id AFFAF61FFA for ; Mon, 28 Dec 2020 17:39:56 +0100 (CET) X-Originating-IP: 2.224.242.101 Received: from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101]) (Authenticated sender: jacopo@jmondi.org) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 1D30124001A; Mon, 28 Dec 2020 16:39:55 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Mon, 28 Dec 2020 17:40:03 +0100 Message-Id: <20201228164003.53051-6-jacopo@jmondi.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201228164003.53051-1-jacopo@jmondi.org> References: <20201228164003.53051-1-jacopo@jmondi.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 5/5] android: camera_device: Simplify properties.get() X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" When accessing the value of a property by reading the properties ControlList content with ControlList::get<>() it is not necessary to specify the template type as it is already conveyed by the Control instance provided as first argument. Reviewed-by: Niklas Söderlund Reviewed-by: Laurent Pinchart Signed-off-by: Jacopo Mondi Reviewed-by: Paul Elder --- src/android/camera_device.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp index bbf016c323a7..7678d4485ce9 100644 --- a/src/android/camera_device.cpp +++ b/src/android/camera_device.cpp @@ -853,7 +853,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata() /* Sensor static metadata. */ if (properties.contains(properties::PixelArraySize)) { const Size &size = - properties.get(properties::PixelArraySize); + properties.get(properties::PixelArraySize); std::vector data{ static_cast(size.width), static_cast(size.height), @@ -872,7 +872,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata() if (properties.contains(properties::PixelArrayActiveAreas)) { const Span &rects = - properties.get>(properties::PixelArrayActiveAreas); + properties.get(properties::PixelArrayActiveAreas); std::vector data{ static_cast(rects[0].x), static_cast(rects[0].y),