From patchwork Fri Dec 18 16:47:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 10683 X-Patchwork-Delegate: jacopo@jmondi.org Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CFECBC0F1A for ; Fri, 18 Dec 2020 16:47:53 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A53B3619AF; Fri, 18 Dec 2020 17:47:52 +0100 (CET) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3C8B16052C for ; Fri, 18 Dec 2020 17:47:50 +0100 (CET) X-Originating-IP: 93.34.118.233 Received: from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233]) (Authenticated sender: jacopo@jmondi.org) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 0A7DF20012 for ; Fri, 18 Dec 2020 16:47:49 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Fri, 18 Dec 2020 17:47:47 +0100 Message-Id: <20201218164754.81422-3-jacopo@jmondi.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201218164754.81422-1-jacopo@jmondi.org> References: <20201218164754.81422-1-jacopo@jmondi.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 2/9] libcamera: properties: ColorFilterArrangement draft property X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Define the 'ColorFilterArrangement' draft property. The property is currently identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart --- This patch introdues the following warnings property_ids.cpp:716: warning: no matching class member found for libcamera::properties::draft::ColorFilterArrangementEnum::RGGB property_ids.cpp:719: warning: no matching class member found for libcamera::properties::draft::ColorFilterArrangementEnum::GRBG property_ids.cpp:722: warning: no matching class member found for libcamera::properties::draft::ColorFilterArrangementEnum::GBRG property_ids.cpp:725: warning: no matching class member found for libcamera::properties::draft::ColorFilterArrangementEnum::BGGR Removing one letter from the identifiers, or adding one, makes the warning disapper: -- 2.29.2 diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml index 411d5b2a398d..8a19b989e6c4 100644 --- a/src/libcamera/property_ids.yaml +++ b/src/libcamera/property_ids.yaml @@ -697,16 +697,16 @@ controls: top-left 2x2 section of the sensor, in reading order. Currently identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT. enum: - - name: RGGB + - name: RGGBZ value: 0 description: RGGB color filter arrangement - - name: GRBG + - name: GRBGZ value: 1 description: GRBG color filter arrangement - - name: GBRG + - name: GBRGZ value: 2 description: GBRG color filter arrangement - - name: BGGR + - name: BGGRZ value: 3 description: BGGR color filter arrangement - name: RGB A Doxygen bug maybe ? --- src/libcamera/property_ids.yaml | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml index f8e32c1bd8cf..411d5b2a398d 100644 --- a/src/libcamera/property_ids.yaml +++ b/src/libcamera/property_ids.yaml @@ -689,4 +689,30 @@ controls: The physical dimensions of the full pixel array in millimeters. Currently identical to ANDROID_SENSOR_INFO_PHYSICAL_SIZE. + - ColorFilterArrangement: + type: int32_t + draft: true + description: | + The arrangement of color filters on sensor; represents the colors in the + top-left 2x2 section of the sensor, in reading order. Currently + identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT. + enum: + - name: RGGB + value: 0 + description: RGGB color filter arrangement + - name: GRBG + value: 1 + description: GRBG color filter arrangement + - name: GBRG + value: 2 + description: GBRG color filter arrangement + - name: BGGR + value: 3 + description: BGGR color filter arrangement + - name: RGB + value: 4 + description: | + Sensor is not Bayer; output has 3 16-bit values for each pixel, + instead of just 1 16-bit value per pixel. + ...