From patchwork Fri Dec 4 06:54:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 10554 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D7863BE177 for ; Fri, 4 Dec 2020 06:55:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A4B79635D6; Fri, 4 Dec 2020 07:55:07 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=uajain.com header.i=@uajain.com header.b="IS0vGEWN"; dkim-atps=neutral Received: from mail.uajain.com (static.126.159.217.95.clients.your-server.de [95.217.159.126]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id ED816635C4 for ; Fri, 4 Dec 2020 07:55:05 +0100 (CET) From: Umang Jain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail; t=1607064905; bh=OMmssAISbEHqoBoqkvh61nTusb+34VnOj2cq0UfiYt4=; h=From:To:Cc:Subject:In-Reply-To:References; b=IS0vGEWN8ciGOyVQ+d8kAoG6vm0PYUXNLbMJV6fLHjmu3fGIBVfV3Hdoc7CMqtZd7 OHrBrNzhmtNdqU9tEBsxSGZvJeUxKqIAcxbfK2b4QCmju0W5wNtbb30zEVn0CObyB9 k63k5mB9GuNG/WS3Nf1UoOhWBnqw5v3yKA7zYY1wZFc1XOQRfalheWT6+BOdwny0lR js/yYZKe2qzW2pK0WZshLUWDvEZFfEKM3R3aktfPc8hPWST2bA1V5++8nRFx+KrNAS VnjbpSra5/dXyAhNqQ610UidXf1lBHg6dwVh8otw7kmzBBvVpK9pBhwdY0amHxJFzh Q5d+pXr3rYgKw== To: libcamera-devel@lists.libcamera.org Date: Fri, 4 Dec 2020 12:24:50 +0530 Message-Id: <20201204065452.2764628-3-email@uajain.com> In-Reply-To: <20201204065452.2764628-1-email@uajain.com> References: <20201204065452.2764628-1-email@uajain.com> Mime-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 2/4] simple-cam: Early return if no cameras are found on the system. X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Failing to do so, the codepath will segfault while trying to acquire a non-existent camera. Signed-off-by: Umang Jain Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- simple-cam.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/simple-cam.cpp b/simple-cam.cpp index e88fb85..aace5c8 100644 --- a/simple-cam.cpp +++ b/simple-cam.cpp @@ -307,6 +307,13 @@ int main() for (std::unique_ptr &request : requests) camera->queueRequest(request.get()); + if (!cm->cameras().size()) { + std::cout << "No cameras were identified on the system." + << std::endl; + cm->stop(); + return EXIT_FAILURE; + } + /* * -------------------------------------------------------------------- * Run an EventLoop