From patchwork Tue Dec 1 17:55:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 10539 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CC263BE176 for ; Tue, 1 Dec 2020 17:55:48 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8C4DD6350D; Tue, 1 Dec 2020 18:55:48 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="uAOnLemO"; dkim-atps=neutral Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id CFE5263504 for ; Tue, 1 Dec 2020 18:55:46 +0100 (CET) Received: by mail-wm1-x343.google.com with SMTP id a3so7527847wmb.5 for ; Tue, 01 Dec 2020 09:55:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=COAYMNMqiriqFstPxQ8fW7J1G1dQjwxxt6BNNdSn0zg=; b=uAOnLemOMv9cCrK2L30Dhi+PAXj2/wLjqUkqGYVcH9sJvtBRxMLxGV7xjUDtEPuINT zStzu67nSJTn7Sik4y9sZSociIzbG+73fShG1IZI2FeZ+Dq1OEwTSavlM9LoQWEuANxb eeVn51cnU40TMZGISlMvSovn3zAVRAdjZp5RLeTGDkqJM6gQ+xku7SHhI+GQGekVPNRs 6EUEC+/eOKLezUKRpE51ZCsLXNRDmrHZf1dOILuN9kYXeY7F7SRYZ9njyBvF6cF44CkP tEdjSxiU1G2fJdDsmQFbtscrmj+YvbGzMDrdy9qJf2Cb2tyLDo6iHF8DJDHKJfQM0SRQ dCGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=COAYMNMqiriqFstPxQ8fW7J1G1dQjwxxt6BNNdSn0zg=; b=tXdlXXXAMfM44Ubl+bp/U6cL1bCBvz/6zNgAfWwCwna4t2t4dmRQFjnVE7+ioSiShL HXgSuY9OoQo0r8sNpTgwK0sOOgQoNqljc+9ah/0/Yf51mTW+Ckmbnuu44h3qbt9iCKLR GKGcjar06fEwD+SUUTN+2msJzfu1F9xIFBaovwlKMkvC5RmBL4EllpMgdsoFqIrFYKGX ckgdXtxlttp/fIzICiTOa1ggWH22DO/FpdowOCdsvUuYUgvtISATqm/OfQAZisc0QF2w jICA1ZSwAD5chC4bRHBMqJcBlNXchCtHDKEl2AewqDzj/fPUhIE/AvNHonawSCfcUv1u 5mHA== X-Gm-Message-State: AOAM531KUqciA++1diyuPRQaala6G/w1H7F7pT032ZYYIeC3KLpXLV4u v+73Tz+LGpms+6QAZ6Zeh8r4vm00NpbwRA5B X-Google-Smtp-Source: ABdhPJyRSnLpVeUDEufytiHV+lBOzxbHL0vKnglAlEz0awiTM4qMzVJKqhPooqxwmLBdyY6hriCv6Q== X-Received: by 2002:a1c:e0d4:: with SMTP id x203mr4040602wmg.68.1606845346340; Tue, 01 Dec 2020 09:55:46 -0800 (PST) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id l3sm438561wrr.89.2020.12.01.09.55.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Dec 2020 09:55:45 -0800 (PST) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Tue, 1 Dec 2020 17:55:35 +0000 Message-Id: <20201201175536.11093-5-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201201175536.11093-1-david.plowman@raspberrypi.com> References: <20201201175536.11093-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 4/5] libcamera: controls: Improve documentation for ExposureTime and AnalogueGain X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Setting these controls "fixes" them and the AE may not change them; setting them back to zero returns them to the control of the AE algorithm. Signed-off-by: David Plowman --- src/libcamera/control_ids.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml index a883e27e..fba1f545 100644 --- a/src/libcamera/control_ids.yaml +++ b/src/libcamera/control_ids.yaml @@ -125,8 +125,15 @@ controls: Exposure time (shutter speed) for the frame applied in the sensor device. This value is specified in micro-seconds. + Setting this value means that it is now fixed and the AE algorithm may + not change it. Setting it back to zero returns it to the control of the + AE algorithm. + \sa AnalogueGain AeEnable + \todo Consider how setting the exposure time interacts with other AE + features, such as aperture, aperture/shutter priority modes etc. + - AnalogueGain: type: float description: | @@ -134,8 +141,15 @@ controls: The value of the control specifies the gain multiplier applied to all colour channels. This value cannot be lower than 1.0. + Setting this value means that it is now fixed and the AE algorithm may + not change it. Setting it back to zero returns it to the control of the + AE algorithm. + \sa ExposureTime AeEnable + \todo Consider how setting the analogue gain interacts with other AE + features, such as aperture, aperture/shutter priority modes etc. + - Brightness: type: float description: |