From patchwork Thu Nov 26 14:23:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 10510 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 3AB0CBE08A for ; Thu, 26 Nov 2020 14:23:31 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D83EA63479; Thu, 26 Nov 2020 15:23:30 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="WD+BbYp7"; dkim-atps=neutral Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3668263469 for ; Thu, 26 Nov 2020 15:23:29 +0100 (CET) Received: by mail-ed1-x531.google.com with SMTP id q3so2438808edr.12 for ; Thu, 26 Nov 2020 06:23:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+NVlZDjzRN8Jm3viX7G6HYZHjp/sXYM7h/3wGLb47/w=; b=WD+BbYp7l8eIBxxcNNrqCYiD2jWTEyGzPHrCHoBEd1qY6BSlAuxudNMiUfu8K+aa2+ OwaGYTaOFA15/thlL9mVtgmQeTPrqk3VB86MMf3Wx2GA7kcEiPMhu+bdHL1MzqLJ9fPc FxCfB3KxRaDWUo082B1qoiefUUTYC2jX6jx0XfKjfNIISlLJ6Rz0p2hpjdHjhN4dXOXY cVNpcrgCxgOuGu8KDajm+abjQP/bbmfplfd36hGvkfUoAJG/E5x05O8wRMU80laSq1DJ FC1jbRoxzRcqnXk4UbghmlbRQOk/EAmJLzNhYvxuSTsIR5eKw9Z79c65tEWYnuPejktU z1AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+NVlZDjzRN8Jm3viX7G6HYZHjp/sXYM7h/3wGLb47/w=; b=kE4uC3C/E+amY7wqdAoQXQ1LN8Y6kvYtZaMOuN/feFBMgptqORujwW6ro6FzEokmVR P+VydJR/3TGsKVu9mOPIL6vgm4oCKOqmS19cyFOUWNU01JPfhF8O6ZgH3ErWTl4LSXnw jRFysxW3zrj6XVLx4LJtVoz3fusUwRuzblt6XO0Rr+TvBhpn971TywVI1DsyaA9SHWbh FjCv/DcEMnOrl+ax45DHwZHyc7mxTPWb6u/Ncp8RnRglsTePGVAhM5XEtvZPe4+ynSlM y20m1jcMPWAZt8Ptg/RG0OrOnq9qKBfqbKk94UkE64SsLmtZYBw3Woqu25NfytCgwK9a 7UwA== X-Gm-Message-State: AOAM531CxMjtZLlkQUTDCj8h0lzpfkAlI/jwqWp8wSVZY8MguziVo6Yw OurpIlZ9t8hGjOZvJ42WFaPXVUi0n3WamQEZ X-Google-Smtp-Source: ABdhPJyE5XahOHpkiCcDLds5n9pKrrgP++onXpaQkVKdkEVOaDXqL7ZOg8UwTYYXqal3Uy40XS66Sg== X-Received: by 2002:aa7:d791:: with SMTP id s17mr2879448edq.272.1606400608657; Thu, 26 Nov 2020 06:23:28 -0800 (PST) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id f24sm3237003edx.90.2020.11.26.06.23.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 06:23:27 -0800 (PST) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Thu, 26 Nov 2020 14:23:21 +0000 Message-Id: <20201126142321.5563-5-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201126142321.5563-1-david.plowman@raspberrypi.com> References: <20201126142321.5563-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 4/4] src: ipa: raspberrypi: Fix initial AGC oscillation for imx219 sensor X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The exposure times in the exposure modes were causing AGC oscillations because the algorithm was demanding long unachievable exposure times but, without working sensor metadata, thought it was getting them when actually it was not. We fix it by making the exposure profile request only achievable exposure times, as we do for the ov5647 tuning. Signed-off-by: David Plowman Reviewed-by: Naushir Patuck Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- src/ipa/raspberrypi/data/imx219.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ipa/raspberrypi/data/imx219.json b/src/ipa/raspberrypi/data/imx219.json index b03a7beb..212f8b9a 100644 --- a/src/ipa/raspberrypi/data/imx219.json +++ b/src/ipa/raspberrypi/data/imx219.json @@ -133,7 +133,7 @@ { "shutter": [ - 100, 10000, 30000, 60000, 120000 + 100, 10000, 30000, 30000, 30000 ], "gain": [ @@ -144,7 +144,7 @@ { "shutter": [ - 100, 5000, 10000, 20000, 120000 + 100, 5000, 10000, 20000, 30000 ], "gain": [