From patchwork Thu Nov 26 14:23:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 10509 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BA83DBE08A for ; Thu, 26 Nov 2020 14:23:30 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 89AB16346A; Thu, 26 Nov 2020 15:23:30 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="ijaPUrGa"; dkim-atps=neutral Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0CA1163472 for ; Thu, 26 Nov 2020 15:23:28 +0100 (CET) Received: by mail-ed1-x531.google.com with SMTP id k1so2430012eds.13 for ; Thu, 26 Nov 2020 06:23:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F4f6KNupEAMJcITnVVSvovunsN/G4z8RTNdi2pn/g+Q=; b=ijaPUrGaBm0DKnfIrH0Y42/ZdQ4RF8gWmG6KioNV1DD6H5XEwfSYeFDfSyyj4E8U+T Bs8+5VpnpFkTtey8b6xg8163zN4eMSwbhtd1/kII8T166A/QsavMJuDXZrM1+X1PFcIz u42IY/Yi/9sZhmBnhWy62mIDnoq5/pl6Mmv4snnGNTApqpeTnTX3oztyjMMzAKio0ekC S8u7KiNKEKoBHtbqOLi+xLw80A9+oAQ5qnZi1Qe/uc2fJOSH1hGIAqG9AE/6t7dRJgzM iWGSrK87oQQjRpJLfq4+24de1uRQcjCLsVZpLwwxB/YPZk5yBjfw6FCXXkCOPsF8uPn7 GTAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F4f6KNupEAMJcITnVVSvovunsN/G4z8RTNdi2pn/g+Q=; b=uUOUC8mIjfmY9sGiWSFDGSJ2zjZCnV9UlsF7U5yvjdHWOa1wr8dpBrT2/X4MJSvln5 0sGH6mn1FyZjx1KvZTxt3ZitMsZAfvKLPk71G0WepFTlTNx4DN8AGBqshVRsQGjbbjFo 6DhnWnoI9MnIpDSrtafKv63atw11kG+bmrVfZyMH2MDeVWLJrzBrrlauncX0b+t6oZZm Ta7JfX1Z66Ky9fLUyilbJRO2sunIevS9t2oMMzITUGEvFZ5STtrwD2WjnuBmVFd3L8ci yRoEOGCxe0DSRJyI+B3DurRep9Bts3y5K1Eanm/bb9NB9VC9PixuJRZSniig5Ong/qp9 nD1Q== X-Gm-Message-State: AOAM5334xVuA+O0W9ZQ4xDt5388s4napwLklXPypqcxb6QOk8lzQai8A K5JDLk+OMr2TXKJuZwwhWm4lm9tabq3YVwbP X-Google-Smtp-Source: ABdhPJw7yh1Uaz+iqdK0MzYTVufayq11vW9ZZMZS4ZqdEpvHMRkidJu+VvxUiBZElaQFobn3R2hWBQ== X-Received: by 2002:aa7:cad2:: with SMTP id l18mr2738964edt.183.1606400607452; Thu, 26 Nov 2020 06:23:27 -0800 (PST) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id f24sm3237003edx.90.2020.11.26.06.23.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 06:23:26 -0800 (PST) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Thu, 26 Nov 2020 14:23:20 +0000 Message-Id: <20201126142321.5563-4-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201126142321.5563-1-david.plowman@raspberrypi.com> References: <20201126142321.5563-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 3/4] src: ipa: raspberrypi: Improve behaviour when AE disabled X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" AE/AGC "disabled" is now handled better by the algorithm for itself, so it no longer needs to be "resumed" before setting fixed shutter or gain values. Signed-off-by: David Plowman Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart Reviewed-by: Laurent Pinchart --- src/ipa/raspberrypi/raspberrypi.cpp | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp index 9853a343..29d48b1b 100644 --- a/src/ipa/raspberrypi/raspberrypi.cpp +++ b/src/ipa/raspberrypi/raspberrypi.cpp @@ -512,10 +512,6 @@ void IPARPi::queueRequest(const ControlList &controls) /* This expects units of micro-seconds. */ agc->SetFixedShutter(ctrl.second.get()); - /* For the manual values to take effect, AGC must be unpaused. */ - if (agc->IsPaused()) - agc->Resume(); - libcameraMetadata_.set(controls::ExposureTime, ctrl.second.get()); break; } @@ -526,10 +522,6 @@ void IPARPi::queueRequest(const ControlList &controls) ASSERT(agc); agc->SetFixedAnalogueGain(ctrl.second.get()); - /* For the manual values to take effect, AGC must be unpaused. */ - if (agc->IsPaused()) - agc->Resume(); - libcameraMetadata_.set(controls::AnalogueGain, ctrl.second.get()); break;