From patchwork Thu Nov 26 12:32:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 10505 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A9A7EBE176 for ; Thu, 26 Nov 2020 12:32:17 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6E6B363467; Thu, 26 Nov 2020 13:32:17 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="inxP2XJr"; dkim-atps=neutral Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 065AA63449 for ; Thu, 26 Nov 2020 13:32:15 +0100 (CET) Received: by mail-ed1-x535.google.com with SMTP id q3so2072579edr.12 for ; Thu, 26 Nov 2020 04:32:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+NVlZDjzRN8Jm3viX7G6HYZHjp/sXYM7h/3wGLb47/w=; b=inxP2XJr5wxY427s1TzVxfg/bV1shgeri0dfZAgmJCro4fNctb10FmwRnHfCkZBpJW sphl+K4bPK6ePubF5rXCmIvvkbkgapJ0TGXNOcFgYQjXsChWIWKrSdhAWpIx4oQBgHli tdu49eyYHJGGpJdgTcP7K2Y6hf4TlWKe8YUY8mNzcn5GQMsoSABCqQ/4fcY1iHpDkVqU 8Op84aojOrJUp3aBByiTLdgFvh6lMhlBcksk2AyIvzkDcPf8UOOa+7PeEHJ0Fu44EpRI ic3ypc75Or2WSMfKOtPRDqaX/QhrYok+LRM50jgFtlmb7LUd3GDA4Um6v5uISWyNBbE9 zXyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+NVlZDjzRN8Jm3viX7G6HYZHjp/sXYM7h/3wGLb47/w=; b=IYtDT5vcm45XStqoemvcd3SuUT6oSW9YQumAgbEehlLlwb/JFP/uUrpJLour3gvn6w LO13cpTm06G2k2WefiFtuP3xLpDWnF3fHG0n8BlVDrOTnLtYVwSHeINskckOk6+N2XvF st8kkdA6bRKF4wU5bbjN5x9SLuJUsMBGnBr6cZ97wVusmAwsIrOvwZlsdc5SQsafEMEX wx73TU8ZzcSlnRrLLygytWIEJX9edNrvNtIQ2J/+3Qu3BdofxR8vJSNsByp0tThgQMnD gVf5ZZHieFRVtYcbZnEwLgNS9TeQWFuYTqmTr9onbxBP7RV/4L6bbKJJqdowwzJ0EFEX x/eQ== X-Gm-Message-State: AOAM530PGLtiaw9pUKYITnG5SZ5wBh+RqhBETjv8GMJPrazVw4cmv60i FQzZNPHLIKo6I8Rso0sqHzhNnJCsgMPxxTRH X-Google-Smtp-Source: ABdhPJyBfnMI2eacxFzh7NlmK7uB88mm4dkAqRM5A+Twv/2HZ8BlGb/e2YnSVdwrn/NUrAj9ZCkWYA== X-Received: by 2002:a05:6402:19b4:: with SMTP id o20mr2280350edz.103.1606393934278; Thu, 26 Nov 2020 04:32:14 -0800 (PST) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id u5sm3064354edp.5.2020.11.26.04.32.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 04:32:13 -0800 (PST) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Thu, 26 Nov 2020 12:32:03 +0000 Message-Id: <20201126123203.19105-5-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201126123203.19105-1-david.plowman@raspberrypi.com> References: <20201126123203.19105-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 4/4] src: ipa: raspberrypi: Fix initial AGC oscillation for imx219 sensor X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The exposure times in the exposure modes were causing AGC oscillations because the algorithm was demanding long unachievable exposure times but, without working sensor metadata, thought it was getting them when actually it was not. We fix it by making the exposure profile request only achievable exposure times, as we do for the ov5647 tuning. Signed-off-by: David Plowman Reviewed-by: Naushir Patuck Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- src/ipa/raspberrypi/data/imx219.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ipa/raspberrypi/data/imx219.json b/src/ipa/raspberrypi/data/imx219.json index b03a7beb..212f8b9a 100644 --- a/src/ipa/raspberrypi/data/imx219.json +++ b/src/ipa/raspberrypi/data/imx219.json @@ -133,7 +133,7 @@ { "shutter": [ - 100, 10000, 30000, 60000, 120000 + 100, 10000, 30000, 30000, 30000 ], "gain": [ @@ -144,7 +144,7 @@ { "shutter": [ - 100, 5000, 10000, 20000, 120000 + 100, 5000, 10000, 20000, 30000 ], "gain": [