From patchwork Wed Nov 25 11:36:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 10496 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A2402BE08A for ; Wed, 25 Nov 2020 11:36:48 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 71AA463411; Wed, 25 Nov 2020 12:36:48 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="pZDBDZMO"; dkim-atps=neutral Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8ACDF6340A for ; Wed, 25 Nov 2020 12:36:46 +0100 (CET) Received: by mail-wr1-x42f.google.com with SMTP id g14so1555333wrm.13 for ; Wed, 25 Nov 2020 03:36:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CE6uEHlIE9O8XYmvvI4ab7mE8mycSjsTt8W0hUgGoYk=; b=pZDBDZMOy3g8HM0Xy4I8mFRiNHhvwkW4TkLTVKXmLANKvvXL/nwk3j52SHAc2CW3mz VT0M28r+cGm/ZAFrkeF7mWIHljaNuNwHZFKXIkS1Ew+3G7LcytfJWkNa8lzAQWKpU6qv +eOBSGeJR7RinridiwjUNzvhwNHA5KhRvcSVixIvw7iv4QjpPMkOLfws2A7qTVnb132J 6OdhwQ3GFYZWHt0RxVqlMwf8PYAtTFowIoXkh3C+FP6cR4HtGRZmcmh1AFid0y6QxQHU 7LHJ/fUA+nbPWUkM1iSXM+Z0RJ0VIqvEIqiybQGFNFQ89d+iYz7qoA6wxhop4KMssPUL 3tTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CE6uEHlIE9O8XYmvvI4ab7mE8mycSjsTt8W0hUgGoYk=; b=KK65O21R9ormomJq6Ja+GJvBZ+/EKx8PZqrAJH6sTSF+a51m2CVVDKBMw77NIOKy0Q SLyr4cirEJCSpGF4TXocpAzLlZvuD+AHKJiDiWfmcpwMxuHgSBbyaxVhz6p6VpV9ASiy +jwGsu0YJqY0ac1lSjNhm0xiHK4S/a2ktQNCCwJ18qb+JZzpDWQ4TTjb9LylYjY0mkhB PIAQ0iUiSQkd0cIYOKKeFEGymJqpdUSV6t4nkEzP5WLqrVXJ+x58xUDCHCYHDyitr7Yi F74mfUk6XAdTkiwi6kHgADr4mPKDE1RTqhjwKmOqTyIxp+fuZhVeqPCPUtxcgkq5izPO nkAA== X-Gm-Message-State: AOAM530FkFaQglXh/7T15tOIPajQWSNn9wcVBY+zlf45A2ZcXxV2006p TFoFEC90JW0OCYNXZSi9dJfMKBkfGhhVxdIW X-Google-Smtp-Source: ABdhPJyzpwId8Om6RMRyva/4Z8sRQXxY/rehZmKDkhpDeAILC6XLUkQ+p0pZYfDqXUTccgFGcQDh+Q== X-Received: by 2002:adf:f98a:: with SMTP id f10mr3663644wrr.154.1606304205971; Wed, 25 Nov 2020 03:36:45 -0800 (PST) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id b14sm4232371wrq.47.2020.11.25.03.36.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Nov 2020 03:36:45 -0800 (PST) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Wed, 25 Nov 2020 11:36:40 +0000 Message-Id: <20201125113640.20246-4-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201125113640.20246-1-david.plowman@raspberrypi.com> References: <20201125113640.20246-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 3/3] src: ipa: raspberrypi: Fix initial AGC oscillation for imx219 sensor X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The exposure times in the exposure modes were causing AGC oscillations because the algorithm was demanding long unachievable exposure times but, without working sensor metadata, thought it was getting them when actually it was not. We fix it by making the exposure profile request only achievable exposure times, as we do for the ov5647 tuning. Signed-off-by: David Plowman Reviewed-by: Naushir Patuck Reviewed-by: Laurent Pinchart --- src/ipa/raspberrypi/data/imx219.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ipa/raspberrypi/data/imx219.json b/src/ipa/raspberrypi/data/imx219.json index b03a7beb..212f8b9a 100644 --- a/src/ipa/raspberrypi/data/imx219.json +++ b/src/ipa/raspberrypi/data/imx219.json @@ -133,7 +133,7 @@ { "shutter": [ - 100, 10000, 30000, 60000, 120000 + 100, 10000, 30000, 30000, 30000 ], "gain": [ @@ -144,7 +144,7 @@ { "shutter": [ - 100, 5000, 10000, 20000, 120000 + 100, 5000, 10000, 20000, 30000 ], "gain": [