From patchwork Mon Nov 23 07:37:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 10462 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8998BBE08A for ; Mon, 23 Nov 2020 07:38:35 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id BD3B56332A; Mon, 23 Nov 2020 08:38:34 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="eqFBNgqC"; dkim-atps=neutral Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3DFB1632B4 for ; Mon, 23 Nov 2020 08:38:33 +0100 (CET) Received: by mail-wr1-x42a.google.com with SMTP id e7so41598wrv.6 for ; Sun, 22 Nov 2020 23:38:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=67Ttd9klxjHbW25ZV2IOb9yHFsznpt0Ki1kGRGQT2Ok=; b=eqFBNgqCCnfZtlu5pMn1pe/NhVfpnJ+4ZtCcpg8ThtHabHKfVnSi1OeDz/JUl6k5Cu Gp7g03sA6Ao0LObj68kbdIGgHazYa2VbsCWC2u+srCxq71Kfx9Ff38O2UlSQlOyY0NKX xJoIHYokfg26/hIEdfeHVsxLuYu9jbnroheeJPFuWe0WcbjvMXI07vulxID2bq2qgz91 lSKY2/mVotXFHgGoFJL0xFEtO6mUjqjVaH9He72SDwMm3E8vWIVKRfbxONmNICWYHA1N IU1Ulued8viG6POPDa3FVlagxAG4siUp2ukSQAONRHrFKv6+1zvDdyaXPJMO7lAMBVN0 pTug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=67Ttd9klxjHbW25ZV2IOb9yHFsznpt0Ki1kGRGQT2Ok=; b=q7oj08AcKr0CxwzWWEaRz3+xOdlDMsplU5VILJS8audOTCLOOH9RZA/wrLWLI7JUhC IcT/5xcKCGdWh5tjjJ8O/0k35UZR1XSnisPLBPyQvZze4aNcI3FG1JACHbSGDE6LI5iv QV3lMQGOP7Ce9d1bQ3ezWgyu1xJV6EquwxDvqpgU7bK/Y1rylho54137X8ZbUv4p4QjM xrZFIwFJloBxJHj5YK7d0hePf2qfRQnLAhI9hMId+43emXIGM+vslbANA5FZ+5Nkws36 e6qoAdmvQuNfGaVW+NtGs0oFqUlZF5CvRVMeWf0nDFd2rvVQjY0pcm/5rUAMrtNoKKEr Vysw== X-Gm-Message-State: AOAM5316I+1h3X0yQyA2bEKhOCS/WjYdwJbvBNqwZ2SvhKyKBBJAb26s 68L/GdGcgFfIV1q91pCG71AYcn6XGSISHElI X-Google-Smtp-Source: ABdhPJxEKPgiIy/VRNyFt9MippLBFDqf/TqZfav85MmXdrTy/Jfg8sMx/p646QM32y9J/+cmABmJbQ== X-Received: by 2002:a5d:4acf:: with SMTP id y15mr21377119wrs.333.1606117112726; Sun, 22 Nov 2020 23:38:32 -0800 (PST) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id h15sm17841822wrw.15.2020.11.22.23.38.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Nov 2020 23:38:32 -0800 (PST) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Mon, 23 Nov 2020 07:37:57 +0000 Message-Id: <20201123073804.3125-4-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201123073804.3125-1-david.plowman@raspberrypi.com> References: <20201123073804.3125-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 03/10] libcamera: ipa: raspberrypi: agc: Rename method to divideUpExposure X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The method formerly known as divvyupExposure is given a more understandable name. Signed-off-by: David Plowman Reviewed-by: Naushir Patuck --- src/ipa/raspberrypi/controller/rpi/agc.cpp | 8 ++++---- src/ipa/raspberrypi/controller/rpi/agc.hpp | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp index 0a67f456..9a5d84f7 100644 --- a/src/ipa/raspberrypi/controller/rpi/agc.cpp +++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp @@ -225,7 +225,7 @@ void Agc::SwitchMode([[maybe_unused]] CameraMode const &camera_mode, // write the results into the metadata we've been given. if (status_.total_exposure_value) { housekeepConfig(); - divvyupExposure(); + divideUpExposure(); writeAndFinish(metadata, false); } } @@ -303,9 +303,9 @@ void Agc::Process(StatisticsPtr &stats, Metadata *image_metadata) bool desaturate = applyDigitalGain(image_metadata, gain, target_Y); // The results have to be filtered so as not to change too rapidly. filterExposure(desaturate); - // The last thing is to divvy up the exposure value into a shutter time + // The last thing is to divide up the exposure value into a shutter time // and analogue_gain, according to the current exposure mode. - divvyupExposure(); + divideUpExposure(); // Finally advertise what we've done. writeAndFinish(image_metadata, desaturate); } @@ -544,7 +544,7 @@ void Agc::filterExposure(bool desaturate) << " no dg " << filtered_.total_exposure_no_dg; } -void Agc::divvyupExposure() +void Agc::divideUpExposure() { // Sending the fixed shutter/gain cases through the same code may seem // unnecessary, but it will make more sense when extend this to cover diff --git a/src/ipa/raspberrypi/controller/rpi/agc.hpp b/src/ipa/raspberrypi/controller/rpi/agc.hpp index 5a02df4e..2442fc03 100644 --- a/src/ipa/raspberrypi/controller/rpi/agc.hpp +++ b/src/ipa/raspberrypi/controller/rpi/agc.hpp @@ -89,7 +89,7 @@ private: bool applyDigitalGain(Metadata *image_metadata, double gain, double target_Y); void filterExposure(bool desaturate); - void divvyupExposure(); + void divideUpExposure(); void writeAndFinish(Metadata *image_metadata, bool desaturate); AgcMeteringMode *metering_mode_; AgcExposureMode *exposure_mode_;