From patchwork Tue Nov 3 15:50:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 10324 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 59BB8BDB89 for ; Tue, 3 Nov 2020 15:51:23 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0D04862C74; Tue, 3 Nov 2020 16:51:23 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="rUCLJFGZ"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 35FCB62BDA for ; Tue, 3 Nov 2020 16:51:20 +0100 (CET) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7B7D6563; Tue, 3 Nov 2020 16:51:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1604418679; bh=1yFu2Wy/3bm0tA+udZuRQXkFa4WmF/o1Sk99FGCTV8s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rUCLJFGZ/5U06ZsuZcDXt27iy2g3T4pDvV3AaDgzSUQ+FiJsR4rb14TNooD9J2ppz DUxb2ZURzmnoh+OoY7kyYvEPxybix5SrmuDTngJyqauRUr2NMdHpbGRdGeP98JAhup L80u4rudyXZ94x/cYE7A8MXx9ESDy8C5xeo45hlQ= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Tue, 3 Nov 2020 17:50:21 +0200 Message-Id: <20201103155025.5948-4-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201103155025.5948-1-laurent.pinchart@ideasonboard.com> References: <20201103155025.5948-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 3/7] qcam: viewfinder_gl: Remove unneeded casts X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" There's no need to cast the yuvData_ unsigned char pointer to a char pointer before performing pointer arithmetics. Drop the unneeded casts. Signed-off-by: Laurent Pinchart Reviewed-by: Andrey Konovalov Reviewed-by: Kieran Bingham Reviewed-by: Niklas Söderlund --- src/qcam/viewfinder_gl.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/qcam/viewfinder_gl.cpp b/src/qcam/viewfinder_gl.cpp index c07292523504..dc35d4fd8505 100644 --- a/src/qcam/viewfinder_gl.cpp +++ b/src/qcam/viewfinder_gl.cpp @@ -360,7 +360,7 @@ void ViewFinderGL::doRender() 0, GL_RG, GL_UNSIGNED_BYTE, - (char *)yuvData_ + size_.width() * size_.height()); + yuvData_ + size_.width() * size_.height()); shaderProgram_.setUniformValue(textureUniformU_, 1); break; @@ -390,7 +390,7 @@ void ViewFinderGL::doRender() 0, GL_RED, GL_UNSIGNED_BYTE, - (char *)yuvData_ + size_.width() * size_.height()); + yuvData_ + size_.width() * size_.height()); shaderProgram_.setUniformValue(textureUniformU_, 1); /* Activate texture V */ @@ -404,7 +404,7 @@ void ViewFinderGL::doRender() 0, GL_RED, GL_UNSIGNED_BYTE, - (char *)yuvData_ + size_.width() * size_.height() * 5 / 4); + yuvData_ + size_.width() * size_.height() * 5 / 4); shaderProgram_.setUniformValue(textureUniformV_, 2); break; @@ -434,7 +434,7 @@ void ViewFinderGL::doRender() 0, GL_RED, GL_UNSIGNED_BYTE, - (char *)yuvData_ + size_.width() * size_.height()); + yuvData_ + size_.width() * size_.height()); shaderProgram_.setUniformValue(textureUniformV_, 2); /* Activate texture U */ @@ -448,7 +448,7 @@ void ViewFinderGL::doRender() 0, GL_RED, GL_UNSIGNED_BYTE, - (char *)yuvData_ + size_.width() * size_.height() * 5 / 4); + yuvData_ + size_.width() * size_.height() * 5 / 4); shaderProgram_.setUniformValue(textureUniformU_, 1); break;