From patchwork Fri Oct 23 10:21:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 10216 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0E217C3D3C for ; Fri, 23 Oct 2020 10:22:09 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A8280615D3; Fri, 23 Oct 2020 12:22:08 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="EJv8oi4B"; dkim-atps=neutral Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 52DDF615D3 for ; Fri, 23 Oct 2020 12:22:06 +0200 (CEST) Received: by mail-wm1-x344.google.com with SMTP id l20so266709wme.0 for ; Fri, 23 Oct 2020 03:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uQQaHb0XmHtsHhkWw0OAl06JWoDByjyQ5++hI8L9kB8=; b=EJv8oi4BI7vfCDdDCz/8w1hBaQLBDqGqNiHq/a0KpxEGFtYfKbUZo7Ah/z1QhvKWyZ d/riNQ8/pHkY/2m26fsuLUX4Tu/yV2G+j7wEbgNx2ryTK4pIUw7BPjJm69EOQmtxA1id 9Q34rwe3VHQLhKdi/ejHBx8NfUzYsirNQPgrTxaUnh4fjQ0B0uvGAI6vKHlccWvGaGwt UcDwr8wgtpL/2LCwsVvEtX1e0Qkrk+nVQBGkin/j6ETDvN2+BzV0oftetN5AMEjf7RoQ az2CWLEZY+aqGx4fZMDu2KS4vJ6Fq5Qaxf1bp5KKSFyE+YjU52Uo+k8GAS7OJnMJHubj sDFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uQQaHb0XmHtsHhkWw0OAl06JWoDByjyQ5++hI8L9kB8=; b=mmFDaaSmGWu87yRuakkhwjTJDG8yIzPGW4vsRvvye2/c1YHEhFtdOLLaHMlGfR6DrX UwzoJp30X9cvwfE91Kn+zP3lhomNk/IumrSZ6cY43KD5ovrDPHmDhDyXkdSfIQaVLWky yEiNCK0CSc++W84QuTTAJ+cXjfNHOvSMOv0nO4aywCb/L7/wQahWnrtAi+Qdj4eJvMNM 4KLeHjKpwOgPKuLGyCIM6hBGD5JrvdB7q/N1fEqWamgIaTY2RAsLCQVGAzo6Nakom0mb FTxnJw6ZSjHaRxo01IPn+pGTUW8EiUKBh1ttkdnE+f1J1omGmlLtF2deRzhOjRZ+SVPh Uaxg== X-Gm-Message-State: AOAM533e4o+wdBnc87KuIdissWg6AaE6qVutBX19gfDTVC9l9hXowDbH 7iY0d/o+wFky9rdEkkelWp0HYHL4V645fg== X-Google-Smtp-Source: ABdhPJwO1BsjvQMns1d3Plw6wG4zmO/luoh8XSPkgieO7pPWT1214MBCuT9tk/J9oPS2SOBiM39AwA== X-Received: by 2002:a1c:7518:: with SMTP id o24mr1623674wmc.137.1603448525868; Fri, 23 Oct 2020 03:22:05 -0700 (PDT) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id r128sm2477831wma.20.2020.10.23.03.22.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Oct 2020 03:22:05 -0700 (PDT) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Fri, 23 Oct 2020 11:21:57 +0100 Message-Id: <20201023102159.26274-4-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201023102159.26274-1-david.plowman@raspberrypi.com> References: <20201023102159.26274-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v5 3/5] libcamera: raspberrypi: Initialise the SensorCropMaximum property X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Initialise it to show we support its use, however, set it to all zeroes to indicate that it's not meaningful yet. Signed-off-by: David Plowman Reviewed-by: Laurent Pinchart --- src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp index dd62dfc7..763451a8 100644 --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp @@ -926,6 +926,13 @@ bool PipelineHandlerRPi::match(DeviceEnumerator *enumerator) /* Initialize the camera properties. */ data->properties_ = data->sensor_->properties(); + /* + * Set a default value for the ScalerCropMaximum property to show + * that we support its use, however, initialise it to zero because + * it's not meaningful until a camera mode has been chosen. + */ + data->properties_.set(properties::ScalerCropMaximum, Rectangle{}); + /* * We cache three things about the sensor in relation to transforms * (meaning horizontal and vertical flips).