From patchwork Fri Oct 23 05:10:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 10206 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BDE18BDB13 for ; Fri, 23 Oct 2020 05:11:16 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8962A615D4; Fri, 23 Oct 2020 07:11:16 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="eYQiW6GV"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 58FC26034E for ; Fri, 23 Oct 2020 07:11:12 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 04B69B26 for ; Fri, 23 Oct 2020 07:11:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1603429872; bh=uvPvY/k7QQs6iSvqiGzvcP6YNky6TFcUjNVR/JS+190=; h=From:To:Subject:Date:In-Reply-To:References:From; b=eYQiW6GVZ00H3lZ3tZjsCQgxjflW1kMK/QL7xQ6yIbIWDjswKvszv33j8l79mpYH/ XPiuano1arg/LslHZcdxiU5PYqkCCXQdGATUUhtA1Q650tJYtLDcRabLfFpXN1XYXU 4qyZ82aOayRjWYaZrrJ5Su7pMsN8cf6Zzu8WXHWA= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Fri, 23 Oct 2020 08:10:20 +0300 Message-Id: <20201023051021.16389-3-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201023051021.16389-1-laurent.pinchart@ideasonboard.com> References: <20201023051021.16389-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 2/3] libcamera: Drop unneeded empty default constructors and destructors X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" A few default constructors and destructors are needlessly defined as empty. Drop them. Signed-off-by: Laurent Pinchart Reviewed-by: Umang Jain Reviewed-by: Kieran Bingham --- include/libcamera/signal.h | 1 - test/media_device/media_device_print_test.cpp | 4 ---- 2 files changed, 5 deletions(-) diff --git a/include/libcamera/signal.h b/include/libcamera/signal.h index accb797e911c..5bcd7a77c5f1 100644 --- a/include/libcamera/signal.h +++ b/include/libcamera/signal.h @@ -38,7 +38,6 @@ template class Signal : public SignalBase { public: - Signal() {} ~Signal() { disconnect(); diff --git a/test/media_device/media_device_print_test.cpp b/test/media_device/media_device_print_test.cpp index 436d4e8af614..cdec5b8da3ec 100644 --- a/test/media_device/media_device_print_test.cpp +++ b/test/media_device/media_device_print_test.cpp @@ -25,10 +25,6 @@ using namespace std; */ class MediaDevicePrintTest : public Test { -public: - MediaDevicePrintTest() {} - ~MediaDevicePrintTest() {} - protected: int init() { return 0; } int run();