From patchwork Thu Oct 22 13:56:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 10203 X-Patchwork-Delegate: kieran.bingham@ideasonboard.com Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 2833AC3D3C for ; Thu, 22 Oct 2020 13:56:16 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id ED20B6145A; Thu, 22 Oct 2020 15:56:15 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="L3e9e8xd"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B809D61478 for ; Thu, 22 Oct 2020 15:56:11 +0200 (CEST) Received: from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5AEFA17C5; Thu, 22 Oct 2020 15:56:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1603374971; bh=aqBQr4hkBETqFM9cnszpdq/GoQiskDhazGi/WzvNye8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L3e9e8xdYWXtO460M2o3jBS9dr8+IqgtkC/6MhJUa1WR4hXv2VBN/4lv0iIwY6f2t QpwptO1/DF7c57Sli+0UWmqIqFF3P5NYgdDBh3/i15vbk9ZHewkB2V/26ws4SA1izi L8yWrANFmwpOheli4KeaxXw/tuzLN5ffnd2TT6iY= From: Kieran Bingham To: libcamera devel Date: Thu, 22 Oct 2020 14:56:05 +0100 Message-Id: <20201022135605.614240-6-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201022135605.614240-1-kieran.bingham@ideasonboard.com> References: <20201022135605.614240-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 5/5] libcamera: MappedBuffer: Delete copy and assignment X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Prevent copying and assignment of MappedBuffer types, which could invoke unmapping or mapped memory. Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- include/libcamera/internal/buffer.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/include/libcamera/internal/buffer.h b/include/libcamera/internal/buffer.h index b7b0173f93f5..8c7126482b95 100644 --- a/include/libcamera/internal/buffer.h +++ b/include/libcamera/internal/buffer.h @@ -10,6 +10,7 @@ #include #include +#include #include #include @@ -34,6 +35,9 @@ protected: int error_; std::vector maps_; + +private: + DELETE_COPY_AND_ASSIGN(MappedBuffer); }; class MappedFrameBuffer : public MappedBuffer