From patchwork Tue Oct 20 05:29:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 10115 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4F4FDBDB13 for ; Tue, 20 Oct 2020 05:29:22 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 15A30613C2; Tue, 20 Oct 2020 07:29:22 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="keOmQSX6"; dkim-atps=neutral Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 067B6610C4 for ; Tue, 20 Oct 2020 07:29:21 +0200 (CEST) Received: by mail-pj1-x1043.google.com with SMTP id gm14so333232pjb.2 for ; Mon, 19 Oct 2020 22:29:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F0hBzpfFTq9B1iOi2sSv4UEXrd/PquHYtGw2Pwrw3M4=; b=keOmQSX6tBUZw7wuxtbgegChtHuKTbOUUsHZffnVkNgE63uj8ppVLBu6cx/2z53HII 3uFavEwB017HrjueHj1dgQCowBxglz1jlCkmGhQR48cJ5aR3DWkdXiwETMzJFFH07hdP I7PH+xV6qqCaXVV7MClyYjbToSCuAOOnRRAGE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F0hBzpfFTq9B1iOi2sSv4UEXrd/PquHYtGw2Pwrw3M4=; b=cLkNWkBeDbR1XaHBA5jyR3+9JHk7vDREEgrTN3iNZmSVy/0SFNFuLM0UhOj5u+5tgj oLvohnmKLlxvqAV9lG0y0gNDpJvl/cHYrpfWPkD0i6emIv5i4pKUan0MyW1/VpQlCKbK O2TeL+jwXaA747s/B0FK3JxcX1BhvLlTgTiIccy3ZZsH+YkwvehHgG3ry/pCa+ixDOvc f5Z0qhwiXQ3t0XeVH7O7hjwSLJ9z2bXCL0eXPalu9GNOZl2JGH7YbJRAgAz/Y5T23uz4 73ppXs8yGL5LgBPHaWWlxjzbjo6KvV2w143AH8R+Kk2+8+rd0ozDKMds2KFJ5/D1Mqwv gLKQ== X-Gm-Message-State: AOAM533ECRTcFhJ5Hcx3Iy3HWWiNjMZ/O+UyI6DRRC5Ckl+8SQdFz0WB zzxlXXY5G+hwNaxdnqQoGCCQ9B5OXn/U+A== X-Google-Smtp-Source: ABdhPJzEDoX3u0zW0bgzujJeE16Kv4pNwBvJpRAo/NnkpX3RDP+ikHob5oszfxub/bJ1184KPDaS9w== X-Received: by 2002:a17:902:6508:b029:d3:b362:72b5 with SMTP id b8-20020a1709026508b02900d3b36272b5mr1250452plk.55.1603171759455; Mon, 19 Oct 2020 22:29:19 -0700 (PDT) Received: from hiroh.tok.corp.google.com ([2401:fa00:8f:2:de4a:3eff:fe7d:f78f]) by smtp.gmail.com with ESMTPSA id j4sm779043pfd.101.2020.10.19.22.29.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 22:29:18 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Oct 2020 14:29:00 +0900 Message-Id: <20201020052905.89267-4-hiroh@chromium.org> X-Mailer: git-send-email 2.29.0.rc1.297.gfa9743e501-goog In-Reply-To: <20201020052905.89267-1-hiroh@chromium.org> References: <20201020052905.89267-1-hiroh@chromium.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 3/8] gstreamer: Omit extra semicolons X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Macros used in gstreamer (e.g. G_DEFINE_TYPE) is a function. The end semicolons with the macros are unnecessary. Signed-off-by: Hirokazu Honda Reviewed-by: Laurent Pinchart --- src/gstreamer/gstlibcamera.cpp | 2 +- src/gstreamer/gstlibcameraallocator.cpp | 2 +- src/gstreamer/gstlibcamerapad.cpp | 2 +- src/gstreamer/gstlibcamerapool.cpp | 2 +- src/gstreamer/gstlibcameraprovider.cpp | 6 +++--- src/gstreamer/gstlibcamerasrc.cpp | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/gstreamer/gstlibcamera.cpp b/src/gstreamer/gstlibcamera.cpp index 81c7bb1..52388b5 100644 --- a/src/gstreamer/gstlibcamera.cpp +++ b/src/gstreamer/gstlibcamera.cpp @@ -24,4 +24,4 @@ plugin_init(GstPlugin *plugin) GST_PLUGIN_DEFINE(GST_VERSION_MAJOR, GST_VERSION_MINOR, libcamera, "libcamera capture plugin", - plugin_init, VERSION, "LGPL", PACKAGE, "https://libcamera.org"); + plugin_init, VERSION, "LGPL", PACKAGE, "https://libcamera.org") diff --git a/src/gstreamer/gstlibcameraallocator.cpp b/src/gstreamer/gstlibcameraallocator.cpp index 78ded40..13c6b49 100644 --- a/src/gstreamer/gstlibcameraallocator.cpp +++ b/src/gstreamer/gstlibcameraallocator.cpp @@ -101,7 +101,7 @@ struct _GstLibcameraAllocator { }; G_DEFINE_TYPE(GstLibcameraAllocator, gst_libcamera_allocator, - GST_TYPE_DMABUF_ALLOCATOR); + GST_TYPE_DMABUF_ALLOCATOR) static gboolean gst_libcamera_allocator_release(GstMiniObject *mini_object) diff --git a/src/gstreamer/gstlibcamerapad.cpp b/src/gstreamer/gstlibcamerapad.cpp index 9f3e2be..c00e81c 100644 --- a/src/gstreamer/gstlibcamerapad.cpp +++ b/src/gstreamer/gstlibcamerapad.cpp @@ -27,7 +27,7 @@ enum { PROP_STREAM_ROLE }; -G_DEFINE_TYPE(GstLibcameraPad, gst_libcamera_pad, GST_TYPE_PAD); +G_DEFINE_TYPE(GstLibcameraPad, gst_libcamera_pad, GST_TYPE_PAD) static void gst_libcamera_pad_set_property(GObject *object, guint prop_id, diff --git a/src/gstreamer/gstlibcamerapool.cpp b/src/gstreamer/gstlibcamerapool.cpp index b756ee3..62db184 100644 --- a/src/gstreamer/gstlibcamerapool.cpp +++ b/src/gstreamer/gstlibcamerapool.cpp @@ -29,7 +29,7 @@ struct _GstLibcameraPool { Stream *stream; }; -G_DEFINE_TYPE(GstLibcameraPool, gst_libcamera_pool, GST_TYPE_BUFFER_POOL); +G_DEFINE_TYPE(GstLibcameraPool, gst_libcamera_pool, GST_TYPE_BUFFER_POOL) static GstFlowReturn gst_libcamera_pool_acquire_buffer(GstBufferPool *pool, GstBuffer **buffer, diff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp index cd850d8..ee44dc7 100644 --- a/src/gstreamer/gstlibcameraprovider.cpp +++ b/src/gstreamer/gstlibcameraprovider.cpp @@ -35,14 +35,14 @@ enum { #define GST_TYPE_LIBCAMERA_DEVICE gst_libcamera_device_get_type() G_DECLARE_FINAL_TYPE(GstLibcameraDevice, gst_libcamera_device, - GST_LIBCAMERA, DEVICE, GstDevice); + GST_LIBCAMERA, DEVICE, GstDevice) struct _GstLibcameraDevice { GstDevice parent; gchar *name; }; -G_DEFINE_TYPE(GstLibcameraDevice, gst_libcamera_device, GST_TYPE_DEVICE); +G_DEFINE_TYPE(GstLibcameraDevice, gst_libcamera_device, GST_TYPE_DEVICE) static GstElement * gst_libcamera_device_create_element(GstDevice *device, const gchar *name) @@ -164,7 +164,7 @@ struct _GstLibcameraProvider { G_DEFINE_TYPE_WITH_CODE(GstLibcameraProvider, gst_libcamera_provider, GST_TYPE_DEVICE_PROVIDER, GST_DEBUG_CATEGORY_INIT(provider_debug, "libcamera-provider", 0, - "libcamera Device Provider")); + "libcamera Device Provider")) static GList * gst_libcamera_provider_probe(GstDeviceProvider *provider) diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp index 5001083..a099508 100644 --- a/src/gstreamer/gstlibcamerasrc.cpp +++ b/src/gstreamer/gstlibcamerasrc.cpp @@ -140,7 +140,7 @@ enum { G_DEFINE_TYPE_WITH_CODE(GstLibcameraSrc, gst_libcamera_src, GST_TYPE_ELEMENT, GST_DEBUG_CATEGORY_INIT(source_debug, "libcamerasrc", 0, - "libcamera Source")); + "libcamera Source")) #define TEMPLATE_CAPS GST_STATIC_CAPS("video/x-raw; image/jpeg")