From patchwork Tue Oct 20 05:28:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 10113 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7BA18BDB13 for ; Tue, 20 Oct 2020 05:29:18 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 49576613BB; Tue, 20 Oct 2020 07:29:18 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="gxxNzWR8"; dkim-atps=neutral Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id AE62060351 for ; Tue, 20 Oct 2020 07:29:16 +0200 (CEST) Received: by mail-pj1-x102c.google.com with SMTP id a1so377173pjd.1 for ; Mon, 19 Oct 2020 22:29:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=V1iPvU62x7joRZHxcSELTFL+1tHF05cp2u/aNWvRiGg=; b=gxxNzWR8DEdsOXz/WNqi+Wf0hJj4qPqZoKdxL70/QVWFuISyeEuASGi+CD/O9YjmPf P6MHtq1Va3EEillv2dnw80pu2PDZ52j+bIgM9eDzu2GDZKoDTngKYTg5caKAMWTp8y6D m7NJe4/QhqxwcZh8Au9mQBTk1+YrDljKuvQe0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=V1iPvU62x7joRZHxcSELTFL+1tHF05cp2u/aNWvRiGg=; b=lB/5VjIE/a+5gYB7fAo/pvuMjx0PI7lxQe2/E6hTfpWXCcwtfOeuF28xDOBtbrrQTS SlZrcD74USuif3bZtjWCimbz49AJF/eq1fz3F9c3hJrxuGXPpFR8RkjZjRbJkMbkB8/y D4cZUnvmAIvYfGeQN9XUaTKtQ12ZeIYhfBW2Nor/TnedRea6oPDy0Al1TUJ1QhCzw5ae OfTh/ZS/OkJjLFAcPNeU71EcpQVZ7U0I+brgIvFRl2Jx9Na/oTw8GRVMWTyg0f074Imw lOtFGBva4iz0QWaCGcT3NjsGT3KOPlHFFVEvtjZIdjG/UxiRRz/oRA+2t2FV+fGRk1wh ltlw== X-Gm-Message-State: AOAM532S7Tf0ym6xUYnhATtpZtXaQQamsJSklXF4X7Y7PZPy9JpMdO7c vKgLgTeogxCYIq4n1PzqXz/L9SsTRn1BBg== X-Google-Smtp-Source: ABdhPJzeO1L+PUM16frgaNI8Q5jmWHEjtIVDpHxubt5EUGf8rjA7kDgMXDL1FT/VTYaibjrCeJ137Q== X-Received: by 2002:a17:902:524:b029:d2:6379:a975 with SMTP id 33-20020a1709020524b02900d26379a975mr1336807plf.61.1603171754635; Mon, 19 Oct 2020 22:29:14 -0700 (PDT) Received: from hiroh.tok.corp.google.com ([2401:fa00:8f:2:de4a:3eff:fe7d:f78f]) by smtp.gmail.com with ESMTPSA id j4sm779043pfd.101.2020.10.19.22.29.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 22:29:14 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Oct 2020 14:28:58 +0900 Message-Id: <20201020052905.89267-2-hiroh@chromium.org> X-Mailer: git-send-email 2.29.0.rc1.297.gfa9743e501-goog In-Reply-To: <20201020052905.89267-1-hiroh@chromium.org> References: <20201020052905.89267-1-hiroh@chromium.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/8] test: Omit extra semicolons X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" TEST_REGISTER macro is main function. The end semicolon with the macro is unnecessary. Signed-off-by: Hirokazu Honda Reviewed-by: Laurent Pinchart --- test/camera/buffer_import.cpp | 2 +- test/camera/capture.cpp | 2 +- test/camera/configuration_default.cpp | 2 +- test/camera/configuration_set.cpp | 2 +- test/camera/statemachine.cpp | 2 +- test/mapped-buffer.cpp | 2 +- test/media_device/media_device_acquire.cpp | 2 +- test/media_device/media_device_link_test.cpp | 2 +- test/media_device/media_device_print_test.cpp | 2 +- test/v4l2_subdevice/list_formats.cpp | 2 +- test/v4l2_subdevice/test_formats.cpp | 2 +- test/v4l2_videodevice/buffer_cache.cpp | 2 +- test/v4l2_videodevice/buffer_sharing.cpp | 2 +- test/v4l2_videodevice/capture_async.cpp | 2 +- test/v4l2_videodevice/controls.cpp | 2 +- test/v4l2_videodevice/double_open.cpp | 2 +- test/v4l2_videodevice/formats.cpp | 2 +- test/v4l2_videodevice/request_buffers.cpp | 2 +- test/v4l2_videodevice/stream_on_off.cpp | 2 +- test/v4l2_videodevice/v4l2_m2mdevice.cpp | 4 ++-- 20 files changed, 21 insertions(+), 21 deletions(-) diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp index 72ce7b7..4b626df 100644 --- a/test/camera/buffer_import.cpp +++ b/test/camera/buffer_import.cpp @@ -168,4 +168,4 @@ private: } /* namespace */ -TEST_REGISTER(BufferImportTest); +TEST_REGISTER(BufferImportTest) diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp index c077080..f13ca53 100644 --- a/test/camera/capture.cpp +++ b/test/camera/capture.cpp @@ -168,4 +168,4 @@ protected: } /* namespace */ -TEST_REGISTER(Capture); +TEST_REGISTER(Capture) diff --git a/test/camera/configuration_default.cpp b/test/camera/configuration_default.cpp index cdd6cb9..c2b2019 100644 --- a/test/camera/configuration_default.cpp +++ b/test/camera/configuration_default.cpp @@ -56,4 +56,4 @@ protected: } /* namespace */ -TEST_REGISTER(ConfigurationDefault); +TEST_REGISTER(ConfigurationDefault) diff --git a/test/camera/configuration_set.cpp b/test/camera/configuration_set.cpp index 30f19ba..a1dc446 100644 --- a/test/camera/configuration_set.cpp +++ b/test/camera/configuration_set.cpp @@ -102,4 +102,4 @@ protected: } /* namespace */ -TEST_REGISTER(ConfigurationSet); +TEST_REGISTER(ConfigurationSet) diff --git a/test/camera/statemachine.cpp b/test/camera/statemachine.cpp index e63ab29..f0c3d77 100644 --- a/test/camera/statemachine.cpp +++ b/test/camera/statemachine.cpp @@ -211,4 +211,4 @@ protected: } /* namespace */ -TEST_REGISTER(Statemachine); +TEST_REGISTER(Statemachine) diff --git a/test/mapped-buffer.cpp b/test/mapped-buffer.cpp index 0279233..5de8201 100644 --- a/test/mapped-buffer.cpp +++ b/test/mapped-buffer.cpp @@ -113,4 +113,4 @@ private: } /* namespace */ -TEST_REGISTER(MappedBufferTest); +TEST_REGISTER(MappedBufferTest) diff --git a/test/media_device/media_device_acquire.cpp b/test/media_device/media_device_acquire.cpp index d1e3d74..371e30e 100644 --- a/test/media_device/media_device_acquire.cpp +++ b/test/media_device/media_device_acquire.cpp @@ -30,4 +30,4 @@ class MediaDeviceAcquire : public MediaDeviceTest } }; -TEST_REGISTER(MediaDeviceAcquire); +TEST_REGISTER(MediaDeviceAcquire) diff --git a/test/media_device/media_device_link_test.cpp b/test/media_device/media_device_link_test.cpp index fe7542b..5c74905 100644 --- a/test/media_device/media_device_link_test.cpp +++ b/test/media_device/media_device_link_test.cpp @@ -219,4 +219,4 @@ class MediaDeviceLinkTest : public MediaDeviceTest } }; -TEST_REGISTER(MediaDeviceLinkTest); +TEST_REGISTER(MediaDeviceLinkTest) diff --git a/test/media_device/media_device_print_test.cpp b/test/media_device/media_device_print_test.cpp index 1f5e3f3..436d4e8 100644 --- a/test/media_device/media_device_print_test.cpp +++ b/test/media_device/media_device_print_test.cpp @@ -151,4 +151,4 @@ int MediaDevicePrintTest::run() return ret; } -TEST_REGISTER(MediaDevicePrintTest); +TEST_REGISTER(MediaDevicePrintTest) diff --git a/test/v4l2_subdevice/list_formats.cpp b/test/v4l2_subdevice/list_formats.cpp index a6044c0..74ec81a 100644 --- a/test/v4l2_subdevice/list_formats.cpp +++ b/test/v4l2_subdevice/list_formats.cpp @@ -79,4 +79,4 @@ int ListFormatsTest::run() return TestPass; } -TEST_REGISTER(ListFormatsTest); +TEST_REGISTER(ListFormatsTest) diff --git a/test/v4l2_subdevice/test_formats.cpp b/test/v4l2_subdevice/test_formats.cpp index 679f50b..47f979e 100644 --- a/test/v4l2_subdevice/test_formats.cpp +++ b/test/v4l2_subdevice/test_formats.cpp @@ -75,4 +75,4 @@ int FormatHandlingTest::run() return TestPass; } -TEST_REGISTER(FormatHandlingTest); +TEST_REGISTER(FormatHandlingTest) diff --git a/test/v4l2_videodevice/buffer_cache.cpp b/test/v4l2_videodevice/buffer_cache.cpp index b22de88..b3f2bec 100644 --- a/test/v4l2_videodevice/buffer_cache.cpp +++ b/test/v4l2_videodevice/buffer_cache.cpp @@ -213,4 +213,4 @@ private: } /* namespace */ -TEST_REGISTER(BufferCacheTest); +TEST_REGISTER(BufferCacheTest) diff --git a/test/v4l2_videodevice/buffer_sharing.cpp b/test/v4l2_videodevice/buffer_sharing.cpp index ba2cc40..5e7e2d9 100644 --- a/test/v4l2_videodevice/buffer_sharing.cpp +++ b/test/v4l2_videodevice/buffer_sharing.cpp @@ -200,4 +200,4 @@ private: unsigned int framesOutput_; }; -TEST_REGISTER(BufferSharingTest); +TEST_REGISTER(BufferSharingTest) diff --git a/test/v4l2_videodevice/capture_async.cpp b/test/v4l2_videodevice/capture_async.cpp index 13cbcc8..2b38102 100644 --- a/test/v4l2_videodevice/capture_async.cpp +++ b/test/v4l2_videodevice/capture_async.cpp @@ -88,4 +88,4 @@ private: unsigned int frames; }; -TEST_REGISTER(CaptureAsyncTest); +TEST_REGISTER(CaptureAsyncTest) diff --git a/test/v4l2_videodevice/controls.cpp b/test/v4l2_videodevice/controls.cpp index 9f09d03..8d42508 100644 --- a/test/v4l2_videodevice/controls.cpp +++ b/test/v4l2_videodevice/controls.cpp @@ -127,4 +127,4 @@ protected: } }; -TEST_REGISTER(V4L2ControlTest); +TEST_REGISTER(V4L2ControlTest) diff --git a/test/v4l2_videodevice/double_open.cpp b/test/v4l2_videodevice/double_open.cpp index 5768d40..7d11f6f 100644 --- a/test/v4l2_videodevice/double_open.cpp +++ b/test/v4l2_videodevice/double_open.cpp @@ -38,4 +38,4 @@ protected: } /* namespace */ -TEST_REGISTER(DoubleOpen); +TEST_REGISTER(DoubleOpen) diff --git a/test/v4l2_videodevice/formats.cpp b/test/v4l2_videodevice/formats.cpp index 043732d..b5020d2 100644 --- a/test/v4l2_videodevice/formats.cpp +++ b/test/v4l2_videodevice/formats.cpp @@ -74,4 +74,4 @@ protected: } }; -TEST_REGISTER(Format); +TEST_REGISTER(Format) diff --git a/test/v4l2_videodevice/request_buffers.cpp b/test/v4l2_videodevice/request_buffers.cpp index 2f8dfe1..fb57714 100644 --- a/test/v4l2_videodevice/request_buffers.cpp +++ b/test/v4l2_videodevice/request_buffers.cpp @@ -26,4 +26,4 @@ protected: } }; -TEST_REGISTER(RequestBuffersTest); +TEST_REGISTER(RequestBuffersTest) diff --git a/test/v4l2_videodevice/stream_on_off.cpp b/test/v4l2_videodevice/stream_on_off.cpp index ce48310..4ed99e9 100644 --- a/test/v4l2_videodevice/stream_on_off.cpp +++ b/test/v4l2_videodevice/stream_on_off.cpp @@ -33,4 +33,4 @@ protected: } }; -TEST_REGISTER(StreamOnStreamOffTest); +TEST_REGISTER(StreamOnStreamOffTest) diff --git a/test/v4l2_videodevice/v4l2_m2mdevice.cpp b/test/v4l2_videodevice/v4l2_m2mdevice.cpp index 44a39d4..616261e 100644 --- a/test/v4l2_videodevice/v4l2_m2mdevice.cpp +++ b/test/v4l2_videodevice/v4l2_m2mdevice.cpp @@ -187,7 +187,7 @@ protected: void cleanup() { delete vim2m_; - }; + } private: std::unique_ptr enumerator_; @@ -201,4 +201,4 @@ private: unsigned int captureFrames_; }; -TEST_REGISTER(V4L2M2MDeviceTest); +TEST_REGISTER(V4L2M2MDeviceTest)