From patchwork Tue Oct 20 00:03:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 10103 X-Patchwork-Delegate: laurent.pinchart@ideasonboard.com Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id AE00BBDB1F for ; Tue, 20 Oct 2020 00:04:09 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 89C96613CA; Tue, 20 Oct 2020 02:04:08 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="YmlK6plK"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4FFFB613BB for ; Tue, 20 Oct 2020 02:04:06 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DFB9693 for ; Tue, 20 Oct 2020 02:04:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1603152246; bh=8BoDIcM4DjyFZqdU4i+gFFnrw+luwGPktI/qKe4uiKw=; h=From:To:Subject:Date:In-Reply-To:References:From; b=YmlK6plKpv1FpZmeJNvrLzRgaYw3fKD1uleBf0WspKkVFqZa20F1Sz0D6uNpqo/u0 Kp52T7LEos2tfrt7vHaIcNOo6q5fri5L8LR7dwJtgxggLzj/Dmp4h4C5x1zCllJGnT tHZYBulBHKZR+8KC1mM/KzJIltEA6yOC4F6eKbmA= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Oct 2020 03:03:08 +0300 Message-Id: <20201020000310.3008-4-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201020000310.3008-1-laurent.pinchart@ideasonboard.com> References: <20201020000310.3008-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 3/5] libcamera: Place doxygen \file block above namespace X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Make the whole code base consistent by placing the doxygen \file block above the libcamera namespace opening. There's a single offender, and two locations in which a white line is missing. Signed-off-by: Laurent Pinchart Reviewed-by: Paul Elder Reviewed-by: Umang Jain Reviewed-by: Kieran Bingham --- src/libcamera/byte_stream_buffer.cpp | 8 ++++---- src/libcamera/v4l2_pixelformat.cpp | 1 + src/libcamera/v4l2_videodevice.cpp | 1 + 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp index df7029b02a7f..eb9003927266 100644 --- a/src/libcamera/byte_stream_buffer.cpp +++ b/src/libcamera/byte_stream_buffer.cpp @@ -12,15 +12,15 @@ #include "libcamera/internal/log.h" -namespace libcamera { - -LOG_DEFINE_CATEGORY(Serialization); - /** * \file byte_stream_buffer.h * \brief Managed memory container for serialized data */ +namespace libcamera { + +LOG_DEFINE_CATEGORY(Serialization); + /** * \class ByteStreamBuffer * \brief Wrap a memory buffer and provide sequential data read and write diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp index 6b05909f56ae..03ab085c1231 100644 --- a/src/libcamera/v4l2_pixelformat.cpp +++ b/src/libcamera/v4l2_pixelformat.cpp @@ -22,6 +22,7 @@ * \file v4l2_pixelformat.h * \brief V4L2 Pixel Format */ + namespace libcamera { LOG_DECLARE_CATEGORY(V4L2) diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp index 508522ef42bb..16162e1edba3 100644 --- a/src/libcamera/v4l2_videodevice.cpp +++ b/src/libcamera/v4l2_videodevice.cpp @@ -32,6 +32,7 @@ * \file v4l2_videodevice.h * \brief V4L2 Video Device */ + namespace libcamera { LOG_DECLARE_CATEGORY(V4L2)