From patchwork Tue Oct 13 15:12:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 10048 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C93F7BEEDF for ; Tue, 13 Oct 2020 15:12:50 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E45A560E91; Tue, 13 Oct 2020 17:12:49 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="tvrJi/6A"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 334B060CE6 for ; Tue, 13 Oct 2020 17:12:47 +0200 (CEST) Received: from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BC175145A; Tue, 13 Oct 2020 17:12:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1602601966; bh=Jyfi7wYROCyEPQP7NodcAjHolsg4ukdOQ9yCEJWSNPo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tvrJi/6AyrfQ9ZclzV/RsmrubKXNVyS9BQ1Myw+SgDiOJihk0iHy5sekNHDtVGttU pOo+z9QTtOv8qtIRu6GpGui2wfHSoHp2PxmPwhXemx+zNOlvqYaEgusAvHJcori8/w 6k/BiU3QRkRcNK5AMLZlgRJng3arIdQ3FrdDtdok= From: Kieran Bingham To: libcamera devel Date: Tue, 13 Oct 2020 16:12:33 +0100 Message-Id: <20201013151241.3557005-3-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201013151241.3557005-1-kieran.bingham@ideasonboard.com> References: <20201013151241.3557005-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 02/10] qcam: main_window: Re-use existing variable X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The queueRequest function creates FrameBuffer pointer which aliases the existing and passed in buffer pointer. When the captureRaw_ scope is executed, the original FrameBuffer *buffer is not used any more. Re-use it rather than creating a new variable with the same name. Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- src/qcam/main_window.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp index 0cbdab9a6bce..0e50768aa386 100644 --- a/src/qcam/main_window.cpp +++ b/src/qcam/main_window.cpp @@ -769,7 +769,7 @@ void MainWindow::queueRequest(FrameBuffer *buffer) request->addBuffer(vfStream_, buffer); if (captureRaw_) { - FrameBuffer *buffer = nullptr; + buffer = nullptr; { QMutexLocker locker(&mutex_);