From patchwork Wed Oct 7 11:07:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 10010 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A6332BEEE1 for ; Wed, 7 Oct 2020 11:08:10 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 73D1F605AF; Wed, 7 Oct 2020 13:08:10 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="o8fBkDrF"; dkim-atps=neutral Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 83E6F60455 for ; Wed, 7 Oct 2020 13:08:08 +0200 (CEST) Received: by mail-lj1-x22f.google.com with SMTP id a5so1522292ljj.11 for ; Wed, 07 Oct 2020 04:08:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nzYDU2E0TJa+hObRpA9YU7WnAsBv5mGDCt8vxp3W3hk=; b=o8fBkDrFnbk+CCVOetv4TbItez7CRn3f3EfrI/3VDQA2HhWymHRALOfUAPgwAoA5UF nmICmgPxXzOLxnQzQP73AgM/sHC43+tvfx6gq27h79OXPwL1l3XoNZnHwrUBOExOilPv 4qDibCBs5+BF+p1uVroaB8nwXABbPqewDOfU7lNm+6S0tiCQcUsbzrXvTHoFzuvsJbUY EC3oq9qAwYOXJ9JEf1rvVAPBdFnPWZb4blAH/11W7O71JaR7WTGKJTRD4JKYKrxcOk4y +JmVecBGnLSoxbWv/3cQOb6zhY0zyarwoloCS2NJGNZ+boPH5jnu/ItxPr+IYCJqNPog qqnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=nzYDU2E0TJa+hObRpA9YU7WnAsBv5mGDCt8vxp3W3hk=; b=AnPYrx2fqpO5LDNbv63S0BBdKZbj54kjPCc45GTwM2DsQWvwvcVNjlydnbEM0x4BQh /MhcSWgH5g0WitYGwO29xqkSZ2X8ZnMBtRvtqYKHvafwhYhLDP5TO4+C2CtMXDPjF6zv F5lwMlszp/C+ApfJ0DsQsdD9CFyUhX9l8yNAf1wL/5RlvFgrgt5HoOQVHBNvQMRQhSXc +f9/bKhq+PYPW3u2sDrTU3AzHtqbILChqLZCOn+nGJR5FzsxhbWZzTnxEQFr2kez57bW 7++wREeXtAJTd1GeJpiIUS7KiVLrzq4U8RsfRYH3QOJtDrh9bDG1hlIPtrcrAP7MIRRg mUFw== X-Gm-Message-State: AOAM531jksOA5ImI3dF3KJDDPVXf61HP3bO8mS1RCktShQ9vRZr1/lg4 IKkKkeFhae1bnG0S0lPHIVLB7i3x0enUrg== X-Google-Smtp-Source: ABdhPJx/dKkCA1N42JgirGHiXUYshexlPAs68u9C2RB7uMPdKWybtyiVrIjnhETebhNlD+M4/sM9mg== X-Received: by 2002:a2e:50a:: with SMTP id 10mr925166ljf.55.1602068887834; Wed, 07 Oct 2020 04:08:07 -0700 (PDT) Received: from deskari.lan (91-152-83-50.elisa-laajakaista.fi. [91.152.83.50]) by smtp.gmail.com with ESMTPSA id x14sm287445lfc.93.2020.10.07.04.08.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2020 04:08:07 -0700 (PDT) From: Tomi Valkeinen To: libcamera-devel@lists.libcamera.org, Naushir Patuck , David Plowman Date: Wed, 7 Oct 2020 14:07:43 +0300 Message-Id: <20201007110743.55561-5-tomi.valkeinen@iki.fi> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201007110743.55561-1-tomi.valkeinen@iki.fi> References: <20201007110743.55561-1-tomi.valkeinen@iki.fi> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 4/4] ipa: raspberrypi: fix use of uninitialized fields X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" These fields are not initialized, but are used. Set them to 0. Signed-off-by: Tomi Valkeinen --- src/ipa/raspberrypi/controller/rpi/agc.hpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ipa/raspberrypi/controller/rpi/agc.hpp b/src/ipa/raspberrypi/controller/rpi/agc.hpp index ba7ae09..23374d5 100644 --- a/src/ipa/raspberrypi/controller/rpi/agc.hpp +++ b/src/ipa/raspberrypi/controller/rpi/agc.hpp @@ -116,9 +116,9 @@ private: std::string exposure_mode_name_; std::string constraint_mode_name_; double ev_; - double flicker_period_; - double fixed_shutter_; - double fixed_analogue_gain_; + double flicker_period_ = 0; + double fixed_shutter_ = 0; + double fixed_analogue_gain_ = 0; }; } // namespace RPiController