From patchwork Wed Sep 30 13:26:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 9872 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E8113C3B5B for ; Wed, 30 Sep 2020 13:23:17 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 505CB622EE; Wed, 30 Sep 2020 15:23:17 +0200 (CEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DC43860364 for ; Wed, 30 Sep 2020 15:23:15 +0200 (CEST) X-Originating-IP: 93.34.118.233 Received: from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233]) (Authenticated sender: jacopo@jmondi.org) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id CC5CBC0007; Wed, 30 Sep 2020 13:23:14 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Wed, 30 Sep 2020 15:26:58 +0200 Message-Id: <20200930132707.19367-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 0/9] android: camera_device: Add support for internal buffers X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: hanlinchen@chromium.org Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Addressed latest comments from Laurent and Kieran. The only missing part is to settle on the owership of the allocator and the buffer queue management, which this series still has in the CameraDevice. As detailed in replies to v3 and private discussions, I don't think it's worth moving them in the CameraStream as it will undergo reworks and in the near future, and moving allocator_ there would require marginally redesigning it. As this series adds a missing feature and actually fixes several tests, I think it's good to go in its current form. Although I agree we're piling a design debt which needs to be addressed by moving CameraStream to become a first class citizen of the HAL and not a CameraDevice internal component. Thanks j Jacopo Mondi (9): android: camera_device: Add CameraStream::Type android: camera_device: Add frame allocator libcamera: frame_buffer_allocator: Add freeAll() android: camera_device: Clear allocator android: camera_device: Clear streams_ in close() android: camera_device: Allocate buffer pools android: camera_device: Add methods to get and return buffers android: camera_device: Use libcamera buffer pool android: camera_device: Add stream mapping log include/libcamera/framebuffer_allocator.h | 1 + src/android/camera_device.cpp | 166 +++++++++++++++++++--- src/android/camera_device.h | 102 ++++++++++++- src/libcamera/framebuffer_allocator.cpp | 8 ++ 4 files changed, 254 insertions(+), 23 deletions(-) --- 2.28.0