From patchwork Fri Sep 25 08:51:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 9821 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id EE9D8C3B5C for ; Fri, 25 Sep 2020 08:51:33 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id BB48A63030; Fri, 25 Sep 2020 10:51:33 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="kh97vAei"; dkim-atps=neutral Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5DBE960576 for ; Fri, 25 Sep 2020 10:51:32 +0200 (CEST) Received: by mail-wr1-x42a.google.com with SMTP id g4so2680301wrs.5 for ; Fri, 25 Sep 2020 01:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KfFdb+VuT1YDJWvnftoUf7kV1pMPOjsCDmOhyzLYasU=; b=kh97vAeiOff0azF+rZwrtlgLnZgvwuLj/rfRH6JizhwBvtU/ac8/T21SasPDACX0mE lV8tYgoPdlT7eRJ5dXnjqpiFsDqF6F6XUZrL+7TmEpwEEkJn7hMtGi/kMzfRWnn+fwWA NgLOVk3HZylg55B8Fv9dft0f/KoCBPCq7NY3ebt8D6DlyGhSA43v8u+AnHqC/QewUUKM plm3vvnfd+UxWyMc82oimeWCwO26ya95AhvN44ZvZnsI2lCNH7WfBdDnm4bRaLvUSuHW 78RkKJuDpgC+Lj8YRO2ORbqrvIvL8hMRTeJavWxauhUIPY8EOMQM3rAla1rPcsVIt4fV FDyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KfFdb+VuT1YDJWvnftoUf7kV1pMPOjsCDmOhyzLYasU=; b=O8Y9BuiOc3q6RmG6dUhoEtQL8d5wRdRoSeBeTxvFajqB0C7mC3hZnfpeGii3L01cp6 NS2L8qHJHpaQoYEIwCeGTSgmKoNn35b7sbHL3BQkNFMYgmsrsIjEYqRK3b0V69rkkQ7N laSXLWflKXPe07DZGOOsvmGPPj4/BeNxXV9w1mLuDpSNGw/HqBZ+F1nMCIEYWxKNtN8J Bfgs57AQby0j+93k2wSyfTwruFBuFvkaJ6fvQHPb1OUFYcPg1qdnVCreHOKs39tlycSu VngarPumKGf/YzdlbVw4j3v5RDOjzPtc3W+ffiQOnh3wnTFBrxsR52ZXdMO2TlpF4aGm i4CA== X-Gm-Message-State: AOAM531EONyJE4IVDiug9FIXi7NKLisWBQGCx1DVfFZYtGwfiohoO943 199qhkXBFbkEEYbs3BwoMa6jVpuVjAw0HQ== X-Google-Smtp-Source: ABdhPJy7E3An9OyzgjSMxx2tF0RIX7OKjuJ3y3e/Zf0ig3G1eEvlM+mHaSVbkgKDEW9o82l0ZBKqSg== X-Received: by 2002:adf:b74b:: with SMTP id n11mr3253210wre.274.1601023891708; Fri, 25 Sep 2020 01:51:31 -0700 (PDT) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id n4sm2001383wrp.61.2020.09.25.01.51.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2020 01:51:31 -0700 (PDT) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Fri, 25 Sep 2020 09:51:21 +0100 Message-Id: <20200925085127.17214-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/6] Digital zoom X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi everyone Here's version 2 of the digital zoom patches. I've applied the various changes that were suggested - so thanks very much for those. The only significant alteration is in the final patch where I had previously added a command-line option to qcam to allow a digital zoom to be requested. This feature has been moved to cam instead... do we think it's useful there? One last question. That example application code that I wrote in a previous message - I wonder if we should try and include it in documentation somewhere? And if so, do we have a natural home for it? I hope that all makes sense! Thanks and best regards David David Plowman (6): libcamera: Add SensorOutputSize property libcamera: Initialise the SensorOutputSize property libcamera: Add IspCrop control libcamera: Add geometry helper functions libcamera: pipeline: raspberrypi: Implementation of digital zoom cam: Add command line option to test IspCrop control include/libcamera/geometry.h | 20 +++ include/libcamera/ipa/raspberrypi.h | 1 + src/cam/capture.cpp | 25 +++- src/cam/capture.h | 2 +- src/cam/main.cpp | 3 + src/cam/main.h | 1 + src/ipa/raspberrypi/raspberrypi.cpp | 7 + src/libcamera/camera_sensor.cpp | 6 + src/libcamera/control_ids.yaml | 9 ++ src/libcamera/geometry.cpp | 129 ++++++++++++++++++ .../pipeline/raspberrypi/raspberrypi.cpp | 47 +++++++ src/libcamera/property_ids.yaml | 19 +++ 12 files changed, 266 insertions(+), 3 deletions(-)