From patchwork Thu Sep 24 09:19:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 9780 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E4EACC3B5B for ; Thu, 24 Sep 2020 09:19:33 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 38D7262FE1; Thu, 24 Sep 2020 11:19:33 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="JcT0ccdL"; dkim-atps=neutral Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8869D60362 for ; Thu, 24 Sep 2020 11:19:31 +0200 (CEST) Received: by mail-wr1-x42f.google.com with SMTP id e16so3009092wrm.2 for ; Thu, 24 Sep 2020 02:19:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5IBW7h4S5BQMfLGqQwOvkK3dwRkQRS5xjIlXjV7DCAk=; b=JcT0ccdL8+omSXBLw2rmL42ZoISaJaIwumWuoolbJuyMLcgy51j++lUn8uORL094UM MBgM9PIf4WT04FbgwZeFPmQyaREezjx7XQwo1OgwMWc3P7RlIeeyzYUVskqzijgiloUV vBmTTUrZGVqfS3+u2ftYzPmqTV8xOj5jKW0kIOgNz+ADXqVHfJcsFj83XBiZK0joxydl adLc1WjKYifxjzrvxsxtQDDV5QpZ2dpuGGmyhG+1Zch3TPtJlZV9kNB4woyDJejN546t LS51dN/k5ggmQm09kpoBN4Q7awiGuTJKFNKLMrMebeW0dRa24+F+nFbiEO66ui+pbL32 FqBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5IBW7h4S5BQMfLGqQwOvkK3dwRkQRS5xjIlXjV7DCAk=; b=SbZZhQXI1A/PHQFr/OwMM0eJDKsQ1DocGwAVWCdegghyvMV0RkvHGg8RNoBpD9p2Kc +q4CE7CoPxfdXp1ff7Zv9pXLYRnwnmilrx2Qyr03cm13cC+rrXi96t3sfUZKyWXaxYRn dKboB62az9TUa43ZLpjxj4hsq8vq/PPl5kG5nMiY8xmb6JZLEBh7f9FvrrleneQaN85H lKdrbgMl+R9MGDrR6Krmol3eVVIDHXpkrEOdhjIxeadEvB3KTK9qQFTwqhSsuIbxgvBN CqjHoH00Y5CYcZbaxgjtxYbZ1VP3heDvGqQfNZmAIv1AqFMl1g55BpN81Zu6IthsV4o3 qArw== X-Gm-Message-State: AOAM531+1j+fIIXrh+BY+jGh0DFBtiZNtSdu6jW9796CxmenDVLVTIud f4/PFfU//R4OJuQT84ZDAQndBaTG9aP13g== X-Google-Smtp-Source: ABdhPJz2Mg2GkhXZe+ehYdJSmYaOZ+4dYYIbpmncpmORNWEW+4RNfpWQtjJKPam9HzsOONwW1EI/Og== X-Received: by 2002:a5d:4c88:: with SMTP id z8mr3982792wrs.218.1600939170822; Thu, 24 Sep 2020 02:19:30 -0700 (PDT) Received: from naushir-VirtualBox.pitowers.org ([2a00:1098:3142:14:a00:27ff:fe4d:f6a2]) by smtp.gmail.com with ESMTPSA id w81sm2689324wmg.47.2020.09.24.02.19.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2020 02:19:30 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Thu, 24 Sep 2020 10:19:23 +0100 Message-Id: <20200924091927.116385-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/4] Code tidy-ups X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, Thank you all for the comments on v1. This v2 update addresses all that was discussed: - Reword commit message for patch 1/4. - Re-order commits 2/4 and 3/4 to have a more logical flow of changes. - Some blank lines added in 4/4 for better code readability. - constexpr int -> constexpr double I have not added an ipa:: namespace. This may warrant some more thought, would we consider adding libcamera core parameters to this namespace, or is it going to be vendor specific? Either way, I think this can be addeded at a later date. Regards, Naush Naushir Patuck (4): pipeline: raspberrypi: Rename RPi::RPiStream and RPi::RPiDevice ipa: raspberrypi: Rename the controller namespace from Rpi to RpiController ipa: raspberrypi: Move IPA parameters to the RPi namespace ipa: raspberrypi: Tidy up variable names to be consistent include/libcamera/ipa/raspberrypi.h | 42 +-- src/ipa/raspberrypi/cam_helper.cpp | 2 +- src/ipa/raspberrypi/cam_helper.hpp | 2 +- src/ipa/raspberrypi/cam_helper_imx219.cpp | 2 +- src/ipa/raspberrypi/cam_helper_imx477.cpp | 2 +- src/ipa/raspberrypi/cam_helper_ov5647.cpp | 2 +- .../raspberrypi/controller/agc_algorithm.hpp | 4 +- src/ipa/raspberrypi/controller/algorithm.cpp | 4 +- src/ipa/raspberrypi/controller/algorithm.hpp | 4 +- .../raspberrypi/controller/awb_algorithm.hpp | 4 +- .../raspberrypi/controller/ccm_algorithm.hpp | 4 +- .../controller/contrast_algorithm.hpp | 4 +- src/ipa/raspberrypi/controller/controller.cpp | 2 +- src/ipa/raspberrypi/controller/controller.hpp | 4 +- src/ipa/raspberrypi/controller/histogram.cpp | 2 +- src/ipa/raspberrypi/controller/histogram.hpp | 4 +- src/ipa/raspberrypi/controller/metadata.hpp | 4 +- src/ipa/raspberrypi/controller/pwl.cpp | 2 +- src/ipa/raspberrypi/controller/pwl.hpp | 4 +- src/ipa/raspberrypi/controller/rpi/agc.cpp | 2 +- src/ipa/raspberrypi/controller/rpi/agc.hpp | 4 +- src/ipa/raspberrypi/controller/rpi/alsc.cpp | 2 +- src/ipa/raspberrypi/controller/rpi/alsc.hpp | 4 +- src/ipa/raspberrypi/controller/rpi/awb.cpp | 2 +- src/ipa/raspberrypi/controller/rpi/awb.hpp | 4 +- .../controller/rpi/black_level.cpp | 2 +- .../controller/rpi/black_level.hpp | 4 +- src/ipa/raspberrypi/controller/rpi/ccm.cpp | 2 +- src/ipa/raspberrypi/controller/rpi/ccm.hpp | 4 +- .../raspberrypi/controller/rpi/contrast.cpp | 2 +- .../raspberrypi/controller/rpi/contrast.hpp | 4 +- src/ipa/raspberrypi/controller/rpi/dpc.cpp | 2 +- src/ipa/raspberrypi/controller/rpi/dpc.hpp | 4 +- src/ipa/raspberrypi/controller/rpi/focus.cpp | 2 +- src/ipa/raspberrypi/controller/rpi/focus.hpp | 4 +- src/ipa/raspberrypi/controller/rpi/geq.cpp | 2 +- src/ipa/raspberrypi/controller/rpi/geq.hpp | 4 +- src/ipa/raspberrypi/controller/rpi/lux.cpp | 2 +- src/ipa/raspberrypi/controller/rpi/lux.hpp | 4 +- src/ipa/raspberrypi/controller/rpi/noise.cpp | 2 +- src/ipa/raspberrypi/controller/rpi/noise.hpp | 4 +- src/ipa/raspberrypi/controller/rpi/sdn.cpp | 2 +- src/ipa/raspberrypi/controller/rpi/sdn.hpp | 4 +- .../raspberrypi/controller/rpi/sharpen.cpp | 2 +- .../raspberrypi/controller/rpi/sharpen.hpp | 4 +- .../controller/sharpen_algorithm.hpp | 4 +- src/ipa/raspberrypi/md_parser.cpp | 2 +- src/ipa/raspberrypi/md_parser.hpp | 2 +- src/ipa/raspberrypi/md_parser_rpi.cpp | 2 +- src/ipa/raspberrypi/md_parser_rpi.hpp | 2 +- src/ipa/raspberrypi/raspberrypi.cpp | 269 +++++++++--------- .../pipeline/raspberrypi/raspberrypi.cpp | 84 +++--- .../pipeline/raspberrypi/rpi_stream.cpp | 38 +-- .../pipeline/raspberrypi/rpi_stream.h | 20 +- 54 files changed, 304 insertions(+), 295 deletions(-)