From patchwork Tue Sep 22 09:50:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 9693 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 18EBEC3B5B for ; Tue, 22 Sep 2020 09:50:34 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7C6B762FD3; Tue, 22 Sep 2020 11:50:33 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="Lb6Zt3aa"; dkim-atps=neutral Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 2B30160364 for ; Tue, 22 Sep 2020 11:50:31 +0200 (CEST) Received: by mail-wr1-x436.google.com with SMTP id z1so16326289wrt.3 for ; Tue, 22 Sep 2020 02:50:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5TDH7pxp7ChMPoW3y9kDh2Euf/B5pkX1IExcbQByQMY=; b=Lb6Zt3aapidww/VEkyxs8y71f229AVL7ybFyS8Su/cNS9vn/JFPQioaVNzXHB8QEyR YYAAGInIf7oJ9kfzd55BafHxRxKWy8wFAfWmqkZh+j5oLb5iPoiInfeI3PSd0ivJbXeJ drJLW/HHNYncMhBC2w7oaIkYTKmgAStE21G8Q7UEkyjOK4XWbfgIkqKymihEXuyZPFdJ aUIycQkz/zjGptlqZH6IEnqFnGh83Yq/kIblDCVUWCoq9rd/x/6sTWij3ebLXuP5ltnc 0Ldx9sm002KXtg6Sozqt88hlzRj+EMh//T8M6qDQD/QdqMjC0oWTMEQ9z40wIlgcKQdl V+ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5TDH7pxp7ChMPoW3y9kDh2Euf/B5pkX1IExcbQByQMY=; b=nkpsRoQmUgBiAdE+wIN6Wt2+7/UQVTOhDYLc+5ycHkxG+WnRsYX1jEpbdN3tWpD7F5 t2kClJzG1/UEwDNrgSqq74krs62LkfTdyhTC0z75ir1hmUxNZCOeK7+C0BmPnAvDQ9a+ GetS/AKx61HL7jPPJQKA6uVXZ1P3lOtJZ7e4FgsDbCTPRSIoyxjqEANE/ptRuq6vWXIN NwR0cpyQ0ase8FZNPmx02b2TqtlFsQwliGk7qRn4pevGQDT/J1eO5SXoXUcGpyLBzqQC q1088p6hRaX1/WKW8f7I4dIFhpYhFFEIMmvFya2xVYyUS7bmwoij/LOpinemapU/FTle 3Hgg== X-Gm-Message-State: AOAM533zIrksfwtkHIbwdW6vcXZHY31+PKWBAVHhtZSLFHjqURuigo71 ajVU/MIHVHlELYNWG6YgLwInNMSq20p+jw== X-Google-Smtp-Source: ABdhPJzwFsDsShuNvyo6OUX1HYDFt/c1Fo7Nr+7ycBsQn7TWOaX/TgYGd/W0idPSrTIkY5tPBnqRlw== X-Received: by 2002:a5d:45cc:: with SMTP id b12mr4315769wrs.395.1600768230461; Tue, 22 Sep 2020 02:50:30 -0700 (PDT) Received: from naushir-VirtualBox.pitowers.org ([2a00:1098:3142:14:a00:27ff:fe4d:f6a2]) by smtp.gmail.com with ESMTPSA id h204sm3776187wmf.35.2020.09.22.02.50.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2020 02:50:29 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Tue, 22 Sep 2020 10:50:14 +0100 Message-Id: <20200922095018.68434-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/4] Code tidy-ups X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, This patch set contains some overdue tidying up of the Raspberry Pi controller, ipa, and pipeline hander code. Mostly moving things into their own namespace and removing the "RPi" prefix off variable names. Note there there are no functional changes in any of the 4 patches, only adding some syntactic sugar :) Thanks, Naush Naushir Patuck (4): pipeline: raspberrypi: Move RPiStream and RPiDevice to its own namespace ipa: raspberrypi: Move IPA parameters to the RPi namespace ipa: raspberrypi: Rename the controller namespace from Rpi to RpiController ipa: raspberrypi: Tidy up variable names to be consistent include/libcamera/ipa/raspberrypi.h | 42 +-- src/ipa/raspberrypi/cam_helper.cpp | 2 +- src/ipa/raspberrypi/cam_helper.hpp | 2 +- src/ipa/raspberrypi/cam_helper_imx219.cpp | 2 +- src/ipa/raspberrypi/cam_helper_imx477.cpp | 2 +- src/ipa/raspberrypi/cam_helper_ov5647.cpp | 2 +- .../raspberrypi/controller/agc_algorithm.hpp | 4 +- src/ipa/raspberrypi/controller/algorithm.cpp | 4 +- src/ipa/raspberrypi/controller/algorithm.hpp | 4 +- .../raspberrypi/controller/awb_algorithm.hpp | 4 +- .../raspberrypi/controller/ccm_algorithm.hpp | 4 +- .../controller/contrast_algorithm.hpp | 4 +- src/ipa/raspberrypi/controller/controller.cpp | 2 +- src/ipa/raspberrypi/controller/controller.hpp | 4 +- src/ipa/raspberrypi/controller/histogram.cpp | 2 +- src/ipa/raspberrypi/controller/histogram.hpp | 4 +- src/ipa/raspberrypi/controller/metadata.hpp | 4 +- src/ipa/raspberrypi/controller/pwl.cpp | 2 +- src/ipa/raspberrypi/controller/pwl.hpp | 4 +- src/ipa/raspberrypi/controller/rpi/agc.cpp | 2 +- src/ipa/raspberrypi/controller/rpi/agc.hpp | 4 +- src/ipa/raspberrypi/controller/rpi/alsc.cpp | 2 +- src/ipa/raspberrypi/controller/rpi/alsc.hpp | 4 +- src/ipa/raspberrypi/controller/rpi/awb.cpp | 2 +- src/ipa/raspberrypi/controller/rpi/awb.hpp | 4 +- .../controller/rpi/black_level.cpp | 2 +- .../controller/rpi/black_level.hpp | 4 +- src/ipa/raspberrypi/controller/rpi/ccm.cpp | 2 +- src/ipa/raspberrypi/controller/rpi/ccm.hpp | 4 +- .../raspberrypi/controller/rpi/contrast.cpp | 2 +- .../raspberrypi/controller/rpi/contrast.hpp | 4 +- src/ipa/raspberrypi/controller/rpi/dpc.cpp | 2 +- src/ipa/raspberrypi/controller/rpi/dpc.hpp | 4 +- src/ipa/raspberrypi/controller/rpi/focus.cpp | 2 +- src/ipa/raspberrypi/controller/rpi/focus.hpp | 4 +- src/ipa/raspberrypi/controller/rpi/geq.cpp | 2 +- src/ipa/raspberrypi/controller/rpi/geq.hpp | 4 +- src/ipa/raspberrypi/controller/rpi/lux.cpp | 2 +- src/ipa/raspberrypi/controller/rpi/lux.hpp | 4 +- src/ipa/raspberrypi/controller/rpi/noise.cpp | 2 +- src/ipa/raspberrypi/controller/rpi/noise.hpp | 4 +- src/ipa/raspberrypi/controller/rpi/sdn.cpp | 2 +- src/ipa/raspberrypi/controller/rpi/sdn.hpp | 4 +- .../raspberrypi/controller/rpi/sharpen.cpp | 2 +- .../raspberrypi/controller/rpi/sharpen.hpp | 4 +- .../controller/sharpen_algorithm.hpp | 4 +- src/ipa/raspberrypi/md_parser.cpp | 2 +- src/ipa/raspberrypi/md_parser.hpp | 2 +- src/ipa/raspberrypi/md_parser_rpi.cpp | 2 +- src/ipa/raspberrypi/md_parser_rpi.hpp | 2 +- src/ipa/raspberrypi/raspberrypi.cpp | 256 +++++++++--------- .../pipeline/raspberrypi/raspberrypi.cpp | 84 +++--- .../pipeline/raspberrypi/rpi_stream.cpp | 38 +-- .../pipeline/raspberrypi/rpi_stream.h | 20 +- 54 files changed, 295 insertions(+), 291 deletions(-) Acked-by: Laurent Pinchart