From patchwork Tue Sep 8 13:41:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 9531 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BD6BFBDB1D for ; Tue, 8 Sep 2020 13:38:05 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 489326056C; Tue, 8 Sep 2020 15:38:05 +0200 (CEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DC7F16036E for ; Tue, 8 Sep 2020 15:38:03 +0200 (CEST) X-Originating-IP: 2.224.242.101 Received: from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101]) (Authenticated sender: jacopo@jmondi.org) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 7CE6F1C0002; Tue, 8 Sep 2020 13:38:02 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Tue, 8 Sep 2020 15:41:31 +0200 Message-Id: <20200908134142.27470-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 00/11] android: camera_device: Fix JPEG/RAW sizes X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: hanlinchen@chromium.org Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This v3 takes into account comments from Laurent and Hiro. To re-cap the goal of the series is: Patches 01->05: - Claim support for JPEG sizes based on the supported YCbCr_888 sizes. - Enumerate the RAW sizes Patches 06->12 The goal is to make CameraStream a class which provides a read-only interface and enforce the creation of CameraStream instances only when all the requested information (size, format and associated libcamera::StreamConfiguration index) are available. In the hope this paves ahead to ease introducing more HAL-only streams by making the CameraStream class the intermediate representation of an Android stream mapped to a libcamera stream. Notabled changes: v2->v3: - Drop return from CameraConfiguration::addConfig() - Make encoder * a unique_ptr in CameraStream - Avoid a few loops and flags as suggested by Laurent and Hiro - Improve debug output Thanks j Jacopo Mondi (11): android: camera_device: Refuse unsupported formats android: camera_device: Generate JPEG sizes android: camera_device: Add debug to stream initialization android: camera_device: Break out size calculation android: camera_device: Generate RAW resolutions android: camera_device: Get rid of stream counter android: camera_device: Use camera3 stream format android: camera_device: Use Android format android: camera_device: Rework CameraStream handling android: camera_device: Set Encoder at construction android: camera_device: Make CameraStream a class src/android/camera_device.cpp | 228 +++++++++++++++++++++------------- src/android/camera_device.h | 31 +++-- 2 files changed, 167 insertions(+), 92 deletions(-) --- 2.28.0