From patchwork Wed Sep 2 13:08:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 9453 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4DEE9BF019 for ; Wed, 2 Sep 2020 13:05:09 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id DFF0A628EE; Wed, 2 Sep 2020 15:05:08 +0200 (CEST) Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 90CE160374 for ; Wed, 2 Sep 2020 15:05:07 +0200 (CEST) Received: from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233]) (Authenticated sender: jacopo@jmondi.org) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 0C6F8100006; Wed, 2 Sep 2020 13:05:04 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Wed, 2 Sep 2020 15:08:39 +0200 Message-Id: <20200902130846.55910-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Subject: [libcamera-devel] [RFC 0/7] android: camera_device: Turn CameraStream into a class X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tfiga@google.com, hiroh@google.com Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" RFC based on the just sent out "[PATCH 0/5] android: camera_device: List JPEG/RAW correct resolutions" series. There are no functional changes in these patches (except for 1/7]), but the end goal is to make CameraStream a class which provides a read-only interface and enforce the creation of CameraStream instances only when all the requested information (size, format and associated libcamera::StreamConfiguration index) are available. In the hope this paves ahead to ease introducing more HAL-only streams by making the CameraStream class the intermediate representation of an Android stream mapped to a libcamera stream. Thanks j Jacopo Mondi (7): libcamera: camera_configuration: Return config index android: camera_device: Get rid of stream counter android: camera_device: Check correct stream format android: camera_device: Use Android format android: camera_device: Rework CameraStream handling android: camera_device: Set Encoder at construction android: camera_device: Make CameraStream a class include/libcamera/camera.h | 2 +- src/android/camera_device.cpp | 95 +++++++++++++++++------------------ src/android/camera_device.h | 23 ++++++--- src/libcamera/camera.cpp | 5 +- 4 files changed, 66 insertions(+), 59 deletions(-) --- 2.28.0