From patchwork Mon Aug 24 20:46:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 9378 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5266FBE174 for ; Mon, 24 Aug 2020 20:46:59 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1C59462886; Mon, 24 Aug 2020 22:46:58 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=uajain.com header.i=@uajain.com header.b="x7LTnJvF"; dkim-atps=neutral Received: from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 47BEA6170D for ; Mon, 24 Aug 2020 22:46:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com; h=from:subject:mime-version:to:cc:content-transfer-encoding: content-type; s=s1; bh=x68/QGoXKPZAeUuahYD68q9TuzaUjle/BJcELKeMLmg=; b=x7LTnJvFV278Mp089sCYGHwBJc0Mpsrfab4oV3jksizeYb3SI1e3uKwPPHYNQ33o5tMv 00Xu9VUG68bysLfGRLzCpN8ot4+RtKAE+mjVCKCmrPvrKN87QceVy1J/8eee1DAFGLhTJd 8dTUKSIYuHeUySQjE9pfKhWvYRXal/pE0= Received: by filterdrecv-p3las1-c4cf4f4c5-xkgx4 with SMTP id filterdrecv-p3las1-c4cf4f4c5-xkgx4-18-5F44273C-54 2020-08-24 20:46:53.121276345 +0000 UTC m=+17333.395237647 Received: from mail.uajain.com (unknown) by ismtpd0006p1maa1.sendgrid.net (SG) with ESMTP id _yV0s2lMQeSzzrDhJ0axzw for ; Mon, 24 Aug 2020 20:46:52.541 +0000 (UTC) From: Umang Jain Date: Mon, 24 Aug 2020 20:46:53 +0000 (UTC) Message-Id: <20200824204646.16866-1-email@uajain.com> Mime-Version: 1.0 X-SG-EID: 1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPc9vLW9W8H4bP+KZ0PPVtun8fdbw/eKUFmYBZIBeqB3eXv3pPcVrLPTgUgIJzscGexFsNuij0gi+DyQ7gOrKNTAHrKRq64Hj6TF18B7QvOPwdgngto8gEhXq0US9zpbXzavs/QRYLynD6CQebyOWtr3a3MZPByxPeod9v4P2kH+kGVNc6T14tUqmVTMI6iPc0O6OU6R6uzxJkYn2jhmNd01Q== To: libcamera-devel@lists.libcamera.org Subject: [libcamera-devel] [PATCH 0/3] Initial EXIF metadata support X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi all, This patch series targets adding initial EXIF metadata support for the frames captured in Android/Libcamera framework. It is initial in the sense, it adds the base infrastructure for Exif metadata support via 'libexif' and also encodes a initial set of metadata tags into the frames. Testing: The testing of this work was carried out via vivid pipeline-handler in conjunction with patch in `cam` using EncoderLibJpeg as the file sink [1]. That way we could see what EXIF metadata could be written and inspect that `exif` or `exiv2` commandline tools. ($) ./build/src/cam/cam -c vivid -C5 -F -s pixelformat=NV12 Sample output (1): exif frame-stream0-000000.jpg EXIF tags in 'frame-stream0-000000.jpg' ('Intel' byte order): --------------------+---------------------------------------------------------- Tag |Value --------------------+---------------------------------------------------------- Image Width |1280 Image Length |720 Manufacturer |Libcamera Model |Camera2111 Orientation |Bottom-left X-Resolution |72 Y-Resolution |72 Resolution Unit |Inch Date and Time |Sun Oct 13 07:03:20 734137 YCbCr Positioning |Centered Exif Version |Exif Version 2.1 Date and Time (Origi|Sun Oct 13 07:03:20 734137 Date and Time (Digit|Sun Oct 13 07:03:20 734137 Components Configura|Y Cb Cr - FlashPixVersion |FlashPix Version 1.0 Color Space |Internal error (unknown value 65535) Pixel X Dimension |1280 Pixel Y Dimension |720 Sample output (2): exiv2 frame-stream0-000000.jpg File name : frame-stream0-000000.jpg File size : 38787 Bytes MIME type : image/jpeg Image size : 1280 x 720 Camera make : Libcamera Camera model : Camera2111 Image timestamp : Sun Oct 13 07:03:20 734137 Image number : Exposure time : Aperture : Exposure bias : Flash : Flash bias : Focal length : Subject distance: ISO speed : Exposure mode : Metering mode : Macro mode : Image quality : Exif Resolution : 1280 x 720 White balance : Thumbnail : None Copyright : Exif comment : There are still a lot of tags that needs to be populated, that can be built on top of this groundwork. [1]: https://github.com/kbingham/libcamera/commit/10ed8ec Kieran Bingham (1): libcamera: android: Add EXIF infrastructure Umang Jain (2): android: jpeg: Pass a Exif object while encoding android: Support initial set of EXIF metadata tags src/android/camera_device.cpp | 12 +- src/android/jpeg/encoder.h | 5 +- src/android/jpeg/encoder_libjpeg.cpp | 15 +- src/android/jpeg/encoder_libjpeg.h | 3 +- src/android/jpeg/exif.cpp | 210 +++++++++++++++++++++++++++ src/android/jpeg/exif.h | 53 +++++++ src/android/meson.build | 2 + 7 files changed, 296 insertions(+), 4 deletions(-) create mode 100644 src/android/jpeg/exif.cpp create mode 100644 src/android/jpeg/exif.h