From patchwork Thu Jul 23 08:43:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 8935 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CC3DDBD86F for ; Thu, 23 Jul 2020 08:43:44 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 48F1B60E78; Thu, 23 Jul 2020 10:43:44 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="J6adSxzu"; dkim-atps=neutral Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E9A6460536 for ; Thu, 23 Jul 2020 10:43:42 +0200 (CEST) Received: by mail-wm1-x32a.google.com with SMTP id w3so4406420wmi.4 for ; Thu, 23 Jul 2020 01:43:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=II9IgKdc1sbVpoFmBBslsrBwimjNPsr/2PruAF1T4dc=; b=J6adSxzu4510FGSM1PvjVBgCNeY33K48k1Qpk526Nl2D+J3tuNFKPkwsxWoQqc9OT2 ZyT8xuJ5BpVZqhdIYkMtokFH/Mf1dY+qX21FDFDyibOMZO/XfI41t84tBj2Z9dWGxm7f +id/un+uLgW9OXOxXDq5nxHYIOu3+n8v8sqzWZL+pO9Pryp5VDvTLcTfiw+p1X4jjeuZ eD2gC8T4y0OoJEWsBOB4W67NW8ss+f1E0Go1idlHkpBiTcEwmyBdIMxaZi/reqsc46W7 yNUVZamjYY7oCrenFv8b55y57oZITcM+RQZOgunVIV73scVLN4DIa5GPFcQofuTG5qes eJmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=II9IgKdc1sbVpoFmBBslsrBwimjNPsr/2PruAF1T4dc=; b=IcvbfEjrqkX6UhRGzkeush50TS8npBeZrAFHvXzd4j6A5aDFWJqHID6qFzMpMLubVl UofrYQT9s7no4oPjiJ8D+1Krz3ukdPBeG1oDcftmsldItb4LBLAGRH+kfXnAyINSlySh 51w/i2jmrI356RkZbwi+9LbIzbA0OpfUgTeqJl2+U3DYw3TSXmDWbHcRj+x5z3DkDA9N iDrhqIpSiyc930eBYz27TZMc7cWHa1SQbGYzXuVKy00QlUCZanJ/5uqvp2Xve68MAiIA 748TstnLLdpJoEgZn9HiCBkym7ActyPtyD9K/y5thLGeeNVBZL284H9qGdKa78vDbhtj 1Nhw== X-Gm-Message-State: AOAM531uAdYuW2jcxH8tNYmCAjhoye38Avr5p73x8XPCBqBpSlKU6Qpb EmNSXWiujJHjF6qJ0bNIpov3zbTDBi7wHg== X-Google-Smtp-Source: ABdhPJw79VZbs2buz3GDy+8FTsAoeH5zNvYJCkVHLhxpAJXwiEYQIFfhxanCkdSO5weIaBeKFugWJA== X-Received: by 2002:a1c:2485:: with SMTP id k127mr3092094wmk.138.1595493822183; Thu, 23 Jul 2020 01:43:42 -0700 (PDT) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id t2sm2809450wmb.25.2020.07.23.01.43.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 01:43:41 -0700 (PDT) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Thu, 23 Jul 2020 09:43:36 +0100 Message-Id: <20200723084338.13711-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/2] Digital zoom implementatino X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi everyone This is a new version of the patch set as promised in my email yesterday. The changes over v2 are as follows: 1. The "sensor crop" has been renamed "pipeline crop" as per that discussion. Obviously I'm still looking for people's guidance on where this should go (or indeed for a better name!). 2. In the second patch I ended up not creating a Rectangle::clip function as the clipping operation performed is not a "straightforward" clip. Nonetheless I made it rather less ugly, and perhaps the result would benefit from going into the Rectangle class after all? Thanks and best regards David David Plowman (2): libcamera: Infrastructure for digital zoom libcamera: raspberrypi: Implement digital zoom include/libcamera/camera.h | 2 + include/libcamera/internal/pipeline_handler.h | 4 ++ include/libcamera/ipa/raspberrypi.h | 1 + src/ipa/raspberrypi/raspberrypi.cpp | 10 +++ src/libcamera/camera.cpp | 27 +++++++ src/libcamera/control_ids.yaml | 10 +++ .../pipeline/raspberrypi/raspberrypi.cpp | 72 +++++++++++++++++++ 7 files changed, 126 insertions(+)