From patchwork Mon Jul 20 10:47:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 8872 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 73BB4C0109 for ; Mon, 20 Jul 2020 10:44:14 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 00EB1605BB; Mon, 20 Jul 2020 12:44:14 +0200 (CEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A50EA6039F for ; Mon, 20 Jul 2020 12:44:12 +0200 (CEST) X-Originating-IP: 93.34.118.233 Received: from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233]) (Authenticated sender: jacopo@jmondi.org) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 2A4EA6000A; Mon, 20 Jul 2020 10:44:11 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Mon, 20 Jul 2020 12:47:17 +0200 Message-Id: <20200720104736.19986-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 00/19] ipu3: rework pipe confiuguration X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, addressed Laurent's most trivial comments on 02 and 03 and 13. Reworked 13 to use the new in-place Size modifiers and expand comments. The series is mostly reviewed in full by Laurent and Niklas, expect from 13/19 and 17/19 which represent the most juicy parts. I plan to push the stand-alone patches not related to the ipu3 pipeline handler to reduce the size of an eventual v5. Thanks j Jacopo Mondi (19): libcamera: ipu3: Rename mbusCodesToInfo libcamera: utils: Add alignUp and alignDown functions libcamera: geometry: Add isNull() function to Rectangle class libcamera: ipu3: Remove streams from generateConfiguration libcamera: ipu3: Make sure the config is valid libcamera: ipu3: cio2: Report format and sizes libcamera: ipu3: Do not overwrite StreamConfiguration libcamera: ipu3: Report StreamFormats libcamera: ipu3: Remove initialization of Size libcamera: ipu3: Validate the stream combination libcamera: camera: Zero streams before validate() libcamera: ipu3: cio2: Add a const sensor() method libcamera: ipu3: Adjust and assign streams in validate() libcamera: ipu3: Remove streams from IPU3CameraConfiguration libcamera: ipu3: Remove camera_ from IPU3CameraConfiguration libcamera: ipu3: imgu: Calculate ImgU pipe configuration libcamera: ipu3: Validate the pipe configuration libcamera: ipu3: Configure ImgU with the computed parameters libcamera: ipu3: imgu: Rename configureInput() include/libcamera/geometry.h | 1 + include/libcamera/internal/utils.h | 10 + src/libcamera/camera.cpp | 4 +- src/libcamera/geometry.cpp | 6 + src/libcamera/pipeline/ipu3/cio2.cpp | 54 +++- src/libcamera/pipeline/ipu3/cio2.h | 6 + src/libcamera/pipeline/ipu3/imgu. | 0 src/libcamera/pipeline/ipu3/imgu.cpp | 378 +++++++++++++++++++++++- src/libcamera/pipeline/ipu3/imgu.h | 22 +- src/libcamera/pipeline/ipu3/ipu3.cpp | 423 +++++++++++++-------------- src/libcamera/utils.cpp | 16 + test/geometry.cpp | 14 + test/utils.cpp | 11 + 13 files changed, 705 insertions(+), 240 deletions(-) create mode 100644 src/libcamera/pipeline/ipu3/imgu. --- 2.27.0