From patchwork Mon Jul 6 23:02:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 8660 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id EAA10BD792 for ; Mon, 6 Jul 2020 23:02:46 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 449BA60E56; Tue, 7 Jul 2020 01:02:46 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="SP136cdl"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id CE8F5603AD for ; Tue, 7 Jul 2020 01:02:44 +0200 (CEST) Received: from Q.local (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4985AAC6; Tue, 7 Jul 2020 01:02:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1594076564; bh=BXzRJUFsOY5XeGYC+LouveOuY0aRKM8q2s+wNnzhjIY=; h=From:To:Cc:Subject:Date:From; b=SP136cdl/3Y4rzfXmp4DFeGORaw/7gqPYDDQznjgcyom2UpzJFzowG8DIbfBvAfy7 MH5l5dgjZPkuYkvszfvAMR5St9GocnnJ0anGYvEEVVf+3QfMNOGdK4YtcCQezmefr8 RWsZrx4YfYAnrhsD1OeHOguaQs8dQNjd/THpeO+E= From: Kieran Bingham To: libcamera devel Date: Tue, 7 Jul 2020 00:02:32 +0100 Message-Id: <20200706230240.2482100-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v5 0/8] android: Multi-stream support X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" A (final?) spin for the multi-stream support in the Android Camera HAL due to v4 being a complete flop and causing a double-free of the Request, where I'm afraid to say I had forgotten that the internal core handles the cleanup of that object. Anyway, that's corrected in "Create the Request and Camera3RequestDescriptor together", and now the multiple-streams are operating again for me, where with some initial JPEG support on top, I can successfully launch the native camera application again. Kieran Bingham (8): libcamera: camera: Allow unspecified roles for generateConfiguration android: camera_device: Provide a toPixelFormat helper android: camera_device: Support multiple stream configurations android: camera_device: Simplify FrameBuffer construction from a buffer_handle_t android: camera_device: Create the Request and Camera3RequestDescriptor together android: camera_device: Maintain a vector of CameraStream android: camera_device: Add buffers for each stream to Requests android: camera_device: Remove single buffer restriction. include/libcamera/camera.h | 2 +- src/android/camera_device.cpp | 183 +++++++++++++++++++++------------- src/android/camera_device.h | 13 +++ 3 files changed, 125 insertions(+), 73 deletions(-)