From patchwork Fri Jul 3 12:39:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 8580 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 3E079BFFE2 for ; Fri, 3 Jul 2020 12:39:25 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id AECDB60C59; Fri, 3 Jul 2020 14:39:24 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="SyQQGcDL"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0AE4D603AE for ; Fri, 3 Jul 2020 14:39:24 +0200 (CEST) Received: from Q.local (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6FEA5296; Fri, 3 Jul 2020 14:39:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1593779963; bh=SbCwIB+wxJcITWLaUom9pXfP1Ybmu7WKedene0Dm25I=; h=From:To:Cc:Subject:Date:From; b=SyQQGcDLYA36tDQHiMvpry44MStnJL/WF3hgUwTe9L93xvAQAvMQyUSVxvXTwy3OV Le1iOhSFzC8lFSXW2rXdM+E+EoIkqZVOoy3Eb4EuLPjKL7FgoJ5mzOi+6EYe8lJmB4 Kf7QXmH4NyGCdaMaq1NFSs8yRQ0tsLz3RVpPpuKw= From: Kieran Bingham To: libcamera devel Date: Fri, 3 Jul 2020 13:39:11 +0100 Message-Id: <20200703123919.2223048-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/8] android: Multi-stream support X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The third iteration for multi-stream support. Following the review comments this morning, things are tidied, and cleaned up and could almost be ready for consumption. With this series, and further work on top to support creation of JPEG streams I have been able to run the native Chrome camera application again. An unrelated change to notifyError has been removed from this series, and the unused halStream in the CameraStream has been removed. Also the CameraStream vector is now clear()ed and resize()d on entry to the configuration function to ensure it's consistent on every call to configrue streams. Aside from that, it's just cleanup and fixups. Kieran Bingham (8): libcamera: camera: Allow unspecified roles for generateConfiguration android: camera_device: Provide a toPixelFormat helper android: camera_device: Support multiple stream configurations android: camera_device: Simplify FrameBuffer construction from a buffer_handle_t android: camera_device: Create the Request and Camera3RequestDescriptor together android: camera_device: Maintain a vector of CameraStream android: camera_device: Add buffers for each stream to Requests android: camera_device: Remove single buffer restriction. include/libcamera/camera.h | 2 +- src/android/camera_device.cpp | 172 ++++++++++++++++++++-------------- src/android/camera_device.h | 12 +++ 3 files changed, 114 insertions(+), 72 deletions(-)