From patchwork Mon Jun 29 10:50:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 8494 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id DDC6CBFFE2 for ; Mon, 29 Jun 2020 10:47:19 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6D3C2609D6; Mon, 29 Jun 2020 12:47:19 +0200 (CEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B965F603B4 for ; Mon, 29 Jun 2020 12:47:18 +0200 (CEST) X-Originating-IP: 93.34.118.233 Received: from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233]) (Authenticated sender: jacopo@jmondi.org) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 411376000B; Mon, 29 Jun 2020 10:47:17 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Mon, 29 Jun 2020 12:50:33 +0200 Message-Id: <20200629105037.14706-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/4] ImageFormat rework X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The main concern raised in v2 was about exposing part of the std::map APIs. In this version I have removed all of them, and users should access the data_ map if the want to iterate on it. Final goal is to get rid of custom maps in pipeline handlers to hold . Once this gets in we can start building on top helpers to create StreamFormats from V4L2VideoDevice::Formats maps. Thanks j Jacopo Mondi (4): libcamera: formats: Make ImageFormats a templated class libcamera: v4l2_subdevice: Provide Formats type alias libcamera: formats: Add ImageFormats::contains() libcamera: v4l2_videodevice: Use ImageFormats include/libcamera/internal/camera_sensor.h | 6 +-- include/libcamera/internal/formats.h | 12 +++--- include/libcamera/internal/v4l2_subdevice.h | 4 +- include/libcamera/internal/v4l2_videodevice.h | 4 +- src/libcamera/formats.cpp | 39 ++++++++++++++----- .../pipeline/raspberrypi/raspberrypi.cpp | 21 +++++----- src/libcamera/pipeline/simple/converter.cpp | 2 +- src/libcamera/pipeline/simple/simple.cpp | 7 ++-- src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 7 ++-- src/libcamera/v4l2_subdevice.cpp | 12 ++++-- src/libcamera/v4l2_videodevice.cpp | 14 +++++-- test/v4l2_subdevice/list_formats.cpp | 2 +- 12 files changed, 81 insertions(+), 49 deletions(-) --- 2.27.0