From patchwork Sun Jun 28 19:09:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Niklas_S=C3=B6derlund?= X-Patchwork-Id: 8481 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 60A93C2E69 for ; Sun, 28 Jun 2020 19:09:31 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A7D5C609E8; Sun, 28 Jun 2020 21:09:30 +0200 (CEST) Received: from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net [195.74.38.229]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 35EE8603B5 for ; Sun, 28 Jun 2020 21:09:29 +0200 (CEST) X-Halon-ID: cc6f1397-b972-11ea-86ee-0050569116f7 Authorized-sender: niklas@soderlund.pp.se Received: from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de [79.202.46.202]) by bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA id cc6f1397-b972-11ea-86ee-0050569116f7; Sun, 28 Jun 2020 21:08:52 +0200 (CEST) From: =?utf-8?q?Niklas_S=C3=B6derlund?= To: libcamera-devel@lists.libcamera.org Date: Sun, 28 Jun 2020 21:09:18 +0200 Message-Id: <20200628190920.3206340-1-niklas.soderlund@ragnatech.se> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/2] libcamera: geometry: Add isNull() function to Size class X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, This is mainly Laurent's work I have just collected the tags and added a small patch on-top to make use of it in the IPU3 pipeline handler. I know the name of the helper (isNull vs isZero vs isValid vs isEmpty) is still debated but I did not wish to lose track of where in the CIO2 the helper should be used disregarding its final name. If I understand things correctly Laurent and myself prefer isNull() while Jacopo and Kieran seems fine with isNull() but would prefer isValid() and isZero() respectively. In other words the perfect bikeshed is almost built :-) Laurent Pinchart (1): libcamera: geometry: Add isNull() function to Size class Niklas Söderlund (1): libcamera: ipu3: cio2: Use Size::isNull() include/libcamera/geometry.h | 1 + src/libcamera/geometry.cpp | 6 ++++++ src/libcamera/pipeline/ipu3/cio2.cpp | 2 +- test/geometry.cpp | 10 ++++++++++ 4 files changed, 18 insertions(+), 1 deletion(-)